#164 - Support for Elm, level 1: Tuples, Lists & Records - #168
Merged
Conversation
AndrewRadev
requested changes
Jul 3, 2020
AndrewRadev
left a comment
AndrewRadev
left a comment
Owner
There was a problem hiding this comment.
Good work! I can't comment on elm specifics, but you seem to have a solid test suite and an implementation that looks very reasonable. I've left some requests for changes mostly on naming and stylistic tweaks. Let me know what you think.
Contributor
Author
|
Thanks @AndrewRadev, all good suggestions :) I'll wave when my PR includes them. |
Contributor
Author
|
@AndrewRadev there it is. Don't hesitate to point out whatever else you might find :) |
AndrewRadev
self-requested a review
July 5, 2020 08:43
AndrewRadev
approved these changes
Jul 5, 2020
AndrewRadev
left a comment
AndrewRadev
left a comment
Owner
There was a problem hiding this comment.
Looks good to me 👍. Will go ahead and merge.
Contributor
Author
|
Great, thanks a lot for all your help :) can't wait to upgrade and use it now :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As promised in issue #164, here we are, the first PR :)
Don't hesitate to point out if you see something I forgot or there's a canonical function I accidentally re-invented, but it seems to do the job and it's quite extensively tested for most problematic cases I could come up with.