Skip to content

Ignore 'Info.Version' in custom OpenAPI doc snapshot test - #1183

Merged
martinothamar merged 3 commits into
mainfrom
chore/ignore-version-in-openapi-snapshot
Mar 12, 2025
Merged

Ignore 'Info.Version' in custom OpenAPI doc snapshot test#1183
martinothamar merged 3 commits into
mainfrom
chore/ignore-version-in-openapi-snapshot

Conversation

@martinothamar

Copy link
Copy Markdown
Contributor

Description

Ignore the 'Info.Version' field in the custom OpenAPI doc snapshot test. The AltinnNugetVersion was giving slightly different results based on GH actions context (release vs normal build)
Also bumps the OpenAPI versjon itself.

Related Issue(s)

  • N/A

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@martinothamar martinothamar added ignore-for-release kind/chore backport-ignore This PR is a new feature and should not be cherry-picked onto release branches labels Mar 12, 2025
@martinothamar martinothamar self-assigned this Mar 12, 2025
@martinothamar martinothamar moved this to 👷 In Progress in Team Apps Mar 12, 2025
@martinothamar martinothamar moved this from 👷 In Progress to 🔎 Review in Team Apps Mar 12, 2025
@martinothamar

Copy link
Copy Markdown
Contributor Author

/publish

@github-actions

github-actions Bot commented Mar 12, 2025

Copy link
Copy Markdown

@martinothamar

Copy link
Copy Markdown
Contributor Author

/publish

@github-actions

github-actions Bot commented Mar 12, 2025

Copy link
Copy Markdown

@martinothamar

Copy link
Copy Markdown
Contributor Author

/publish

@github-actions

github-actions Bot commented Mar 12, 2025

Copy link
Copy Markdown

PR release:

⚙️ Building...
✅ Done!

@martinothamar
martinothamar enabled auto-merge (squash) March 12, 2025 13:53

@HauklandJ HauklandJ left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@martinothamar
martinothamar merged commit 6d02993 into main Mar 12, 2025
@martinothamar
martinothamar deleted the chore/ignore-version-in-openapi-snapshot branch March 12, 2025 13:54
@github-project-automation github-project-automation Bot moved this from 🔎 Review to 🧪 Test in Team Apps Mar 12, 2025
@martinothamar

Copy link
Copy Markdown
Contributor Author

cc @ivarne, I tried to add the assertion on the diagnostics when deserializing as well, but there were some issues:

image

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-ignore This PR is a new feature and should not be cherry-picked onto release branches ignore-for-release kind/chore

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants