Refactor auto response

[micahwoodard]

Refactors auto response to auto reward. On auto reward trials, reward is given immediately after go cue and trial resume as normal after. Skips reward in reward response period if auto reward.

closes #118

[bruno-f-cruz]

It is not clear to me this is the intended logic. For instance, if auto-reward trials, you still want animals to wait for "RewardDelayduration" and "RewardConsumptionDuration"? I modified it to skip the reward delay (since the reward has already been delivered) but to keep waiting the reward consumption since the subject still has to collect the reward. We can modify further if needed.

There were a few bugs I detected in case it helps:

1. you probably wanted to use zip not merge to check the condition between the trial type and the IsRewarded
2. The current condition is not longer symmetrical; as a result, if IsRewarded == True and IsAutoReward is not null, if i am understanding correctly, the state machine will get stuck forever.

[micahwoodard]

It is not clear to me this is the intended logic. For instance, if auto-reward trials, you still want animals to wait for "RewardDelayduration" and "RewardConsumptionDuration"? I modified it to skip the reward delay (since the reward has already been delivered) but to keep waiting the reward consumption since the subject still has to collect the reward. We can modify further if needed.

@bruno-f-cruz I was implementing it based on this comment . It seems like logic should be the reward was delivered immediately after the go cue and then the trial proceeded normally after except that no other reward is given. @alexpiet is that correct?

[bruno-f-cruz]

It is not clear to me this is the intended logic. For instance, if auto-reward trials, you still want animals to wait for "RewardDelayduration" and "RewardConsumptionDuration"? I modified it to skip the reward delay (since the reward has already been delivered) but to keep waiting the reward consumption since the subject still has to collect the reward. We can modify further if needed.

@bruno-f-cruz I was implementing it based on this comment . It seems like logic should be the reward was delivered immediately after the go cue and then the trial proceeded normally after except that no other reward is given. @alexpiet is that correct?

Fair enough! I changed the implementation to match those requirements. The reward delay is now also implemented for the non-existing reward during auto-water trials. I guess worst case scenario, people can set it to 0.

[micahwoodard]

@arjunsridhar12345 just a heads up this introduces breaking changes by renaming is_auto_response_right to is_auto_reward_right. The logic should remain the same though