fix: import order violation in ESM modules and untyped API response - #818
Open
saurabhhhcodes wants to merge 1 commit into
Open
fix: import order violation in ESM modules and untyped API response#818saurabhhhcodes wants to merge 1 commit into
saurabhhhcodes wants to merge 1 commit into
Conversation
- Move AVATAR_API constant after imports in RealTimeContext.tsx (invalid ESM — imports must precede all code) - Move DEVPATH_API constant after imports in InteractiveBackground.tsx (same ESM violation) - Guard setNews(data) in CodingNews.tsx: validate that API response is an array before setting; fall back to FALLBACK_NEWS on mismatch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugs fixed:
ESM import order violation (RealTimeContext.tsx):
AVATAR_APIconstant declared beforeimportstatement — invalid ESM syntax that can break strict build tools.ESM import order violation (InteractiveBackground.tsx): Same pattern —
DEVPATH_APIconstant declared before imports.Untyped API response (CodingNews.tsx):
setNews(data)accepted arbitrary JSON without validating it matchesNewsItem[]. Added array check with graceful fallback toFALLBACK_NEWS.Verification: