Fix some obscure swizzle upgrade bugs - #2637
Conversation
|
Hmmm, while writing test cases I found out that a freshly created swizzle node gets completely ignored. Not good. We need to convert that into a constant |
|
Tested against Still one remaining issue of the nitpick type. The |
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
Thanks for diving into these tricky edge cases, @JGamache-autodesk, and the changes look good to me!
32bdd68
into
AcademySoftwareFoundation:main
Was working on upgrading a MaterialX material when it is written using UsdShade data model, and that required reviewing the current upgrade code to convert it to Python/USD. Also was working on a unit test, which forced me to put on my QA hat and start devising devious ways to fail the code.
This resulted in the following two fixes for extremely rare corner cases.