-
Notifications
You must be signed in to change notification settings - Fork 73
fix: Add ARM64 Alpine compatibility for frontend Docker build #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,8 +5,12 @@ WORKDIR /app | |
| # Copy package files | ||
| COPY package.json package-lock.json ./ | ||
|
|
||
| # Install dependencies | ||
| RUN npm ci | ||
| # Install dependencies - use npm install instead of npm ci to handle optional deps better | ||
| # and explicitly install rollup ARM64 Alpine binary if needed | ||
| RUN npm install && \ | ||
| if [ "$(uname -m)" = "aarch64" ]; then \ | ||
| npm install --no-save @rollup/rollup-linux-arm64-musl || true; \ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing version causes rollup native binary mismatchHigh Severity The |
||
| fi | ||
|
|
||
| # Copy application code | ||
| COPY . . | ||
|
|
||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Silent failure masks ARM64 binary installation errors
Medium Severity
The
|| trueat the end of thenpm install @rollup/rollup-linux-arm64-muslcommand silently suppresses all errors, including legitimate failures like network issues or version incompatibilities. When running on ARM64 architecture, if this installation fails for a real reason, the Docker build succeeds but the container will fail at runtime when Vite/Rollup tries to use the missing native binary. This creates a confusing failure mode where builds appear successful but containers are broken.