Architecture Validation: 4 violations found (2 critical)

[vybe]

Automated Architecture Validation Report

Date: 2026-04-24
Result: 4 invariant violations found — 2 critical (P0-P1) require attention

---

Critical Findings (P0-P1)

Invariant #1 — Three-Layer Backend: SQL in Routers

Routers must not contain raw SQL. Violations found:

• src/backend/routers/processes.py lines 777–865: cursor = conn.cursor(), CREATE TABLE IF NOT EXISTS process_schedules, INSERT OR REPLACE INTO process_schedules, DELETE FROM process_schedules
• src/backend/routers/voice.py lines 176–306: Direct cursor.execute("UPDATE agent_ownership ...") and cursor.execute("SELECT voice_system_prompt ...")
• src/backend/routers/triggers.py line 252: cursor.execute("SELECT * FROM process_schedules ...")

SQL must move to db/ layer modules per the Router → Service → DB invariant.

Invariant #3 — Schema in db/schema.py, Migrations in db/migrations.py

CREATE TABLE statements found outside the designated files:

• src/backend/routers/processes.py line 781: CREATE TABLE IF NOT EXISTS process_schedules (ad-hoc, no migration)
• src/backend/services/process_engine/services/alerts.py line 163: CREATE TABLE IF NOT EXISTS cost_thresholds
• src/backend/services/process_engine/services/alerts.py line 178: CREATE TABLE IF NOT EXISTS cost_alerts
• src/backend/services/process_engine/services/templates.py line 117: CREATE TABLE IF NOT EXISTS process_templates
• src/backend/services/process_engine/repositories/audit.py: CREATE TABLE audit_entries
• src/backend/services/process_engine/repositories/sqlite_definitions.py: CREATE TABLE process_definitions
• src/backend/services/process_engine/repositories/sqlite_executions.py: CREATE TABLE process_executions, step_executions
• src/backend/services/process_engine/repositories/sqlite_events.py: CREATE TABLE execution_events

All DDL must live in db/schema.py with versioned migrations in db/migrations.py.

---

Non-Critical Findings (P2-P3, informational)

Invariant #6 — Frontend: Store = Domain, View = Page

Direct api.get() / api.post() calls found in view files (should go through Pinia stores):

• ProcessList.vue, ProcessWizard.vue, ProcessEditor.vue — 8 violations

Invariant #7 — Single API Client (api.js)

Raw fetch() calls scattered outside api.js — 19+ occurrences in views, components, and router:

• AgentDetail.vue, Approvals.vue, ApiKeys.vue, FileManager.vue, ChatPanel.vue, FilesPanel.vue, HostTelemetry.vue, router/index.js, etc.

Invariant #10 — Process Engine: DDD Isolation

Routers importing directly from process_engine.domain (should go through service layer):

• routers/processes.py, routers/triggers.py, routers/executions.py, routers/approvals.py

Invariant #15 — Pydantic Models Centralized in models.py

60+ model class definitions scattered across router files instead of in models.py:

• fan_out.py, processes.py, settings.py, executions.py, alerts.py, slack.py, and many more

---

Recommended Actions

1. [P1] Extract SQL from processes.py, voice.py, triggers.py into db/ layer modules following the existing XOperations mixin pattern
2. [P1] Move process_schedules and all Process Engine CREATE TABLE statements into db/schema.py with corresponding migrations in db/migrations.py
3. [P2] Migrate Process view API calls (ProcessEditor.vue, ProcessList.vue, ProcessWizard.vue) to use Pinia stores
4. [P2] Consolidate router-local models (processes.py, settings.py, etc.) into models.py

---

Generated by scheduled /validate-architecture run

[AndriiPasternak31]

Closing as resolved by #430 + voice.py refactor

Resolution date: 2026-04-26
Verified against commit: 81a78f4
Resolved by: e901108 — refactor(#430): delete process engine

This automated report was generated 2026-04-24 against a snapshot taken before commit e901108 landed. e901108 deleted the entire Process Engine (142 files changed, 49,588 deletions), making 6 of the 7 cited findings stale on main. The remaining citation (voice.py:176-306) was independently refactored to use db.get_voice_system_prompt() / db.set_voice_system_prompt().

Verification table

#	Invariant	Files cited in #479	Verified status on 81a78f4	Evidence
1	SQL in routers	processes.py, triggers.py	Files deleted (#430)	git ls-files src/backend/routers/processes.py → empty
1	SQL in routers	voice.py:176-306	Refactored (clean)	grep -rE 'cursor\.execute|conn\.execute|\\bcursor\\b' src/backend/routers/ → 0 matches
3	Schema/migrations	8 process_engine repository files	All deleted (#430)	grep -rE 'CREATE TABLE' src/backend/ → matches only in db/schema.py, db/migrations.py
6	Frontend store/view	ProcessList.vue, ProcessWizard.vue, ProcessEditor.vue	Files deleted (#430)	ls src/frontend/src/views/Process*.vue → no matches
10	Process Engine DDD isolation	processes.py, triggers.py, executions.py, approvals.py	All deleted (#430)	ls src/backend/services/process_engine/ → no such directory

Both P1-critical findings resolved on main

The two P1 findings that drove this issue's priority-p1 label are gone:

• Invariant Fix: Add missing Docker labels to system agent container #1 (SQL in routers): 0 violations on 81a78f4.
• Invariant Feature/vector log retention #3 (CREATE TABLE outside schema): 0 violations on 81a78f4.

Residual findings split into separate tracking issues

The two P2-non-critical patterns from #479 (Invariant #6/#7 raw fetch in views; Invariant #14 scattered Pydantic models) are still present and decaying (#14 went from 63 BaseModels in 20 routers → 71 in 25 in one cycle). A fresh re-validation today also surfaces invariant #8 (inline auth sprawl, 85 matches > 5 threshold) which the original 2026-04-24 run missed.

These have been split out to a new tracked issue rather than left in this stale automated report:

• fix(validate-architecture): add stale-citation filter + issue dedupe guard #511 — fix /validate-architecture skill correctness: stale-citation filter + open-issue dedupe guard. The upstream cause of this false-positive issue.
• (filed alongside this comment) — track residual real architecture drift: invariants Feature/process engine #6/security: Fix token logging and add HTML reports to gitignore #7, security: implement safe tar extraction with symlink/hardlink validation #8, Add internal health route, without which main didn't start #14.

Why this isn't 'just close' — root cause addressed

The reason #479 was filed in the first place is the /validate-architecture skill's Step 4 had no file-existence filter on cited paths and no dedupe guard before gh issue create. Without fixing the skill, the next scheduled run would file an analogous false-positive. PR fixing the skill is on branch AndriiPasternak31/arch-479 and closes #511.

Closing.

[vybe]

Closing as superseded — the underlying violations were either resolved by #430 (Process Engine removal) or are tracked separately in #512 (residual architecture drift: inline auth sprawl, scattered models, raw fetch). The auto-report's false-positive citations to deleted Process Engine files are addressed by #511 (stale-citation filter for /validate-architecture).