Add agent diagnostic telemetry vocabulary - #38
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
83c9e61 to
d0185c7
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0185c73af
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "description": "qyl-owned vocabulary, first-class next to the pinned upstream registries (qyl architecture, loop 1). Attributes here are qyl.* names the platform emits and the collector must recognize; scope_names are the ActivitySource/Meter names qyl constructs; event_names are qyl-owned Activity or DiagnosticSource event names. Consumed by emit_analyzer_registry.py (QYL0200/QYL0201 allowlists). Entries under qyl.mcp.* are the experimental staging namespace: deletion-targeted on every upstream registry bump that lands an equivalent.", | ||
| "attributes": [ | ||
| { | ||
| "key": "qyl.agent.diagnostic.extension.id", |
There was a problem hiding this comment.
Feed the qyl vocabulary into every registry projection
When consumers use the advertised source-generation, public-registry, or TypeSpec paths, none of these new entries are visible: RegistryLoader, emit_registry_resources.py, and emit_typespec_keys.py read only resolved-registry.json, which contains no qyl.* catalog rows or the new event. Consequently, generating the qyl prefix produces no diagnostic/workflow constants, OpenResolvedRegistry() omits the vocabulary, and the qyl-api-schema projection cannot expose these correlation keys. Merge qyl-registry.json into the shared projection rather than loading it only in the attribute and analyzer emitters.
AGENTS.md reference: AGENTS.md:L3-L5
Useful? React with 👍 / 👎.
Summary
qyl.agent.diagnostic.snapshotevent.Stack role
Telemetry-vocabulary foundation for:
Validation
The final tree passed:
VerifyAttributesHash,emit_attributes.py --check,emit_analyzer_registry.py --check,emit_registry_resources.py --check, andverify_deprecated_catalog.pyA local Release build attempt was canceled after it stopped producing output; it is not counted as validation.