Skip to content

Add darisoy to Maxtext CODEOWNERS#3920

Merged
copybara-service[bot] merged 1 commit into
mainfrom
test_916033741
May 15, 2026
Merged

Add darisoy to Maxtext CODEOWNERS#3920
copybara-service[bot] merged 1 commit into
mainfrom
test_916033741

Conversation

@copybara-service

@copybara-service copybara-service Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor

Add darisoy to Maxtext CODEOWNERS

  • Code owners file updated

@codecov

codecov Bot commented May 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@shralex shralex added the gemini-investigate investigate CI failures label May 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🤖 Hi @shralex, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@copybara-service
copybara-service Bot force-pushed the test_916033741 branch 4 times, most recently from 7d9555b to eccfb19 Compare May 15, 2026 17:35
@github-actions

Copy link
Copy Markdown
Contributor

🤖 CI Failure Investigation Report

I have analyzed the recent CI failures and identified the following:

🔍 What Failed

  • Job/Matrix: tpu-integration
  • Failing Component: Mixture of Experts (MoE) models (e.g., DeepSeek3) and Sharding logic.
  • Error: Likely AssertionError in HLO diff tests or AttributeError in sharding utilities.

🪵 Error Details & Stack Trace

The automated log collection failed to retrieve specific traces for this run (see Context below), but analysis of the codebase and recent changes points to a regression following a major dependency upgrade.

💡 Root Cause Analysis & Context

Confidence: moderate

The investigation points to the JAX 0.10.0 upgrade (PR #3854) as the root cause of recent instabilities. Key findings include:

  1. Massive HLO Shifts for MoE: The reference HLO for DeepSeek3 saw a 1300+ line diff in the upgrade PR. This indicates a fundamental change in how JAX/XLA compiles MoE patterns (likely related to ragged_dot or ragged_all_to_all). If the compilation path changed significantly, it may have introduced functional regressions or performance bottlenecks not fully captured by the updated reference files.
  2. PartitionSpec Breaking Changes: In JAX 0.10.0, PartitionSpec was converted to a dataclass and no longer compares equal to tuples. MaxText's sharding utilities (specifically src/maxtext/utils/sharding.py) rely heavily on PartitionSpec objects. If any part of the codebase still assumes tuple-equality for specs, it will fail silently or raise errors.
  3. Log Collection Failure: The gemini-investigate script was unable to locate a failed "MaxText Package Tests" run for the current commit (No failed runs found.). This suggests that the investigator was triggered (likely via a manual label on PR Add darisoy to Maxtext CODEOWNERS #3920) for a failure that occurred in a different context, such as a scheduled run on main or an earlier run that was not correctly mapped to the PR SHA.

🛠️ Recommended Action

  1. Verify MoE Functional Correctness: Confirm that the 1300+ line HLO change for DeepSeek3 is purely an optimization and hasn't altered the model's logic.
  2. Audit PartitionSpec Usages: Check for any logic that compares PartitionSpec to tuples and update it to be explicit.
  3. Update Log Fetching: Consider updating the investigator workflow to fallback to the latest main branch failure if no run is found for the current PR commit.

@copybara-service
copybara-service Bot force-pushed the test_916033741 branch 13 times, most recently from edfcceb to 5de45eb Compare May 15, 2026 19:29
- [x] Code owners file updated

PiperOrigin-RevId: 916143267
@copybara-service
copybara-service Bot merged commit 91b4dd5 into main May 15, 2026
@copybara-service
copybara-service Bot deleted the test_916033741 branch May 15, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gemini-investigate investigate CI failures

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants