Skip to content

Add Description API - #163

Open
mm-hsh wants to merge 2 commits into
developfrom
1276-description
Open

Add Description API #163
mm-hsh wants to merge 2 commits into
developfrom
1276-description

Conversation

@mm-hsh

@mm-hsh mm-hsh commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

This pull request introduces a new Description API endpoint, providing a self-describing service descriptor with supported profiles. It implements the API, handler, service, and domain model, and adds comprehensive unit and integration tests. Additionally, it registers the new services in dependency injection. Some test code cleanup and minor refactoring are also included.

Description API Implementation:

  • Added DescriptionController with a GET endpoint at /description that returns a list of supported profiles as a service descriptor (ServiceDescriptionDto). [1] [2]
  • Implemented DescriptionHandler and IDescriptionHandler to encapsulate the logic for retrieving the service descriptor. [1] [2]
  • Added a mapping profile to convert the domain model (ServiceDescription) to the DTO (ServiceDescriptionDto).
  • Introduced the domain model ServiceDescription and its DTO representation. [1] [2]
  • Implemented DescriptionService and IDescriptionService to provide the supported profiles. [1] [2]

Dependency Injection:

  • Registered the new handler and service in the application's dependency injection setup. [1] [2]

Testing:

  • Added unit tests for the controller, handler, mapping profile, and service. [1] [2] [3] [4]
  • Added integration tests for the Description API endpoint.

Test Code Cleanup:

  • Removed unused usings and methods from DiscoveryControllerTests for clarity and maintainability. [1] [2] [3]

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

…ManifestProvider and PluginManifestConflictHandler
@sonarqubecloud

sonarqubecloud Bot commented Jul 7, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Test & Coverage Report

Test Results Summary

Metric Count
✅ Passed 1358
❌ Failed 0
⏭️ Skipped 0

View Detailed Test Results


Code Coverage

Unit Tests Coverage

Package Line Rate Branch Rate Complexity Health
AAS.TwinEngine.DataEngine 90% 78% 1947
Summary 90% (3075 / 3405) 78% (1291 / 1658) 1947

Minimum allowed line rate is 80%

Module Tests Coverage

Package Line Rate Branch Rate Complexity Health
AAS.TwinEngine.DataEngine 61% 42% 1947
Summary 61% (2066 / 3405) 42% (703 / 1658) 1947

@mm-hsh
mm-hsh requested review from mm-asha and mm-kgi July 7, 2026 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants