feat: define atomic capability contract v1 - #9
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.github.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the Atomic Capability Execution Model (ADR 0009) to establish a stable control-plane contract for independently executable capabilities, including JSON schemas and a PowerShell test script to validate envelope coherence. Feedback on the test script includes addressing cross-platform path compatibility, specifying PowerShell version requirements, preventing array unwrapping in JSON conversion, and correcting a missing comma in an array definition.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| $registryPath = Join-Path $root "orchestration\integrations.json" | ||
| $contractPath = Join-Path $root "orchestration\capability-contract.v1.json" | ||
| $schemaPath = Join-Path $root "orchestration\schemas\code-intel-capability-envelope.v1.schema.json" | ||
| $documentationPaths = @( | ||
| (Join-Path $root "CONTEXT.md"), | ||
| (Join-Path $root "docs\atomic-development-model.md"), | ||
| (Join-Path $root "docs\adr\0009-atomic-capability-execution-model.md"), | ||
| (Join-Path $root "docs\code-intel-architecture.md") | ||
| ) |
There was a problem hiding this comment.
Using backslashes (\) in path strings passed to Join-Path will cause cross-platform failures on Linux and macOS, as the backslash is treated as a literal character in the filename rather than a directory separator. Since the PR description explicitly targets Windows, macOS, and Linux CI guards, please use forward slashes (/) in all path strings. PowerShell and .NET automatically normalize forward slashes to backslashes on Windows.
$registryPath = Join-Path $root "orchestration/integrations.json"
$contractPath = Join-Path $root "orchestration/capability-contract.v1.json"
$schemaPath = Join-Path $root "orchestration/schemas/code-intel-capability-envelope.v1.schema.json"
$documentationPaths = @(
(Join-Path $root "CONTEXT.md"),
(Join-Path $root "docs/atomic-development-model.md"),
(Join-Path $root "docs/adr/0009-atomic-capability-execution-model.md"),
(Join-Path $root "docs/code-intel-architecture.md")
)
| param( | ||
| [string]$RepoPath = $PSScriptRoot | ||
| ) |
There was a problem hiding this comment.
To ensure that this script is only executed in environments that support PowerShell Core (v7.2+), where cmdlets like Test-Json are natively available, it is highly recommended to add a #requires -Version 7.2 statement at the very top of the file. This prevents cryptic 'cmdlet not found' errors when run on older Windows PowerShell 5.1 environments.
#requires -Version 7.2
param(
[string]$RepoPath = $PSScriptRoot
)
| function ConvertTo-CanonicalFixtureJson { | ||
| param([Parameter(Mandatory = $true)]$Value) | ||
| return ($Value | ConvertTo-Json -Depth 20 -Compress) | ||
| } |
There was a problem hiding this comment.
Piping $Value to ConvertTo-Json can cause PowerShell to unwrap single-element arrays, converting them to single JSON objects instead of JSON arrays. To preserve the exact structure of $Value (especially when dealing with collections), use the -InputObject parameter directly instead of the pipeline.
function ConvertTo-CanonicalFixtureJson {
param([Parameter(Mandatory = $true)]$Value)
return (ConvertTo-Json -InputObject $Value -Depth 20 -Compress)
}
| @{ name = "result snapshot mismatch"; apply = { param($d, $q, $r) $r.snapshotIdentity = "c" * 64 } } | ||
| @{ name = "output artifact snapshot mismatch"; apply = { param($d, $q, $r) $r.artifacts[0].consumedSnapshotIdentity = "c" * 64 } } |
There was a problem hiding this comment.
There is a missing comma at the end of line 243, which makes the array definition syntactically inconsistent with the other elements. Adding a comma ensures robust parsing and prevents issues if the array is ever reformatted or joined onto a single line.
@{ name = "result snapshot mismatch"; apply = { param($d, $q, $r) $r.snapshotIdentity = "c" * 64 } },
@{ name = "output artifact snapshot mismatch"; apply = { param($d, $q, $r) $r.artifacts[0].consumedSnapshotIdentity = "c" * 64 } }
v0.3.0-beta.1 feat: move Sentrux DSM analysis to Rust
|
Closing after a merge-readiness review at main HEAD 384617f (2026-07-28). Why close rather than merge:
Salvageable pieces (worth re-doing as small fresh PRs on top of main, if still wanted): the Windows sentrux-shim launch fixes, the |
1 participant
Stacked on #8. Establishes the Linux-style atomic control-plane contract without claiming runtime decomposition: a Draft-07 envelope schema, Artifact Ref and Snapshot Identity, Effect Boundary, outcome matrix, cross-envelope coherence, ADR/docs, and Windows/macOS/Linux CI guards. Runtime executor, cache, publication, and portable artifact work remain separate LM Wiki atoms.