Skip to content

fix(gate): 禁用 quotePath 修非 ASCII 路径漏匹配 + hardened_git 单一声明 - #108

Merged
2233admin merged 1 commit into
mainfrom
fix/gate-followup
Aug 1, 2026
Merged

fix(gate): 禁用 quotePath 修非 ASCII 路径漏匹配 + hardened_git 单一声明#108
2233admin merged 1 commit into
mainfrom
fix/gate-followup

Conversation

@2233admin

Copy link
Copy Markdown
Owner

CodeRabbit 对 #102 的合并后追审两条,快速跟进:

  1. quotePath(Major,真 bug)run_git_diff_numstat / file_commit_history 解析路径输出时未禁用 core.quotePath——非 ASCII 文件名默认被 C 引号转义("src/\347\273\237..."),永远匹配不上仓库相对路径键,非 ASCII 路径的历史/统计会漏。两处子进程加 -c core.quotePath=false,带中文文件名 fixture 回归测试 non_ascii_paths_arrive_unquoted_from_git。对中文用户仓库这是必修。
  2. 模块声明收敛(nitpick):移除 change_risk/mod.rs#[path = "../hardened_git.rs"] 二次声明(同文件双模块实例),全部改走 crate::hardened_git

门禁:change_risk 12/12、全套测试无失败、cargo fmt --check 干净、权威 self-scan exit 0。

Refs #95

CodeRabbit 追审两条(PR #102 合并后到达):
- run_git_diff_numstat / file_commit_history 加 -c core.quotePath=false——非 ASCII 路径默认被 C 引号转义,永远匹配不上仓库相对路径键,历史/统计会漏文件;带回归测试(中文文件名 fixture)。
- change_risk/mod.rs 移除 #[path] 二次声明,统一走 crate::hardened_git,消除同文件双模块实例。

Refs #95
@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@repowise-bot

repowise-bot Bot commented Aug 1, 2026

Copy link
Copy Markdown

🔒 Repowise is not analyzing this repository

The PR bot is free on public repositories. This one is private, which needs a Pro plan.

See plans · Manage this repository

@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@2233admin, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 27 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b91e630d-fad3-4675-b177-90d14761e26c

📥 Commits

Reviewing files that changed from the base of the PR and between 47e5941 and f26b8ad.

📒 Files selected for processing (3)
  • crates/code-intel-cli/src/change_risk/git.rs
  • crates/code-intel-cli/src/change_risk/mod.rs
  • crates/code-intel-cli/src/change_risk/tests.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown

Code Intel change risk

Score Percentile Level
36/100 10th (vs last 49 commits) 🟢 low

Top signals

  • Diff shape: 3 file(s), +43/-11 (max file share 0.54)
  • Test asymmetry: source changed, no tests touched
  • Bug-magnet: 0 fix commit(s) in touched files (180d)
  • Churn: 3 commit(s) touching these files (90d)

revspec: origin/main..HEAD · threshold: percentile >= 90 blocks unless labeled risk-accepted · code-intel change risk

@2233admin
2233admin merged commit 0255735 into main Aug 1, 2026
8 checks passed
@2233admin
2233admin deleted the fix/gate-followup branch August 1, 2026 19:10
2233admin added a commit that referenced this pull request Aug 1, 2026
北极星落地批次:PR 门禁占位(#102/#108)、eval 双臂基准立裁判(#107/#109)、docs 生命周期首扫 + out-of-scope 注册表(#109/#116)、第二仓冷启动出自举圈(#110,摩擦 #111-#115 立案)。

版本绑定点同步:Cargo.toml + orchestration/toolchain-versions.v1.json + Cargo.lock。
门禁证据:cargo test 无失败、权威 self-scan exit 0、retirement packet 套件 8/8、repin clean。
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant