Skip to content

Commit 3bd1964

Browse files
incognitojamgithub-actions[bot]
authored andcommitted
fix(web): align thread-row draft icon with upstream draft glyph (#69)
Upstream `pingdotgg#5777` introduced draft-session rows in the sidebar using an amber `SquarePenIcon`, while our thread-row unsent-draft indicator (#23) still used `PencilIcon` — two glyphs for the same "unsent composer content" concept. This swaps the thread-row indicator to `SquarePenIcon` so drafts read consistently, keeping the muted colour treatment (rather than upstream's amber) since on a thread row it's a quiet status flag alongside the terminal and PR badges, not a block asking for a decision. Size (`size-3.5`) and hover behaviour are unchanged. | Before | After | | --- | --- | | ![before](https://raw.githubusercontent.com/yngatech/t3code/assets/pr-69-draft-icon/before.png) | ![after](https://raw.githubusercontent.com/yngatech/t3code/assets/pr-69-draft-icon/after.png) | Screenshots show the indicator on the "Fix flaky nightly changelog test" row (a thread with unsent composer text) while another thread is open.
1 parent 8a218e4 commit 3bd1964

1 file changed

Lines changed: 8 additions & 6 deletions

File tree

apps/web/src/components/Sidebar.tsx

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ import {
4444
FolderPlusIcon,
4545
GitBranchIcon,
4646
MessageSquareIcon,
47-
PencilIcon,
4847
PinIcon,
4948
PlusIcon,
5049
SearchIcon,
@@ -1128,15 +1127,18 @@ const SidebarThreadRow = memo(function SidebarThreadRow(props: {
11281127
aria-label="Unsent draft"
11291128
data-testid={`sidebar-v2-draft-${thread.id}`}
11301129
className={cn(
1131-
// Matches the PR badge's settled treatment: muted at rest so the
1132-
// parked tail stays quiet, brightening with the row on hover. The
1133-
// pencil has no state colour of its own, so it lifts to the same
1134-
// foreground the title does.
1130+
// Same glyph as the draft-session rows so "unsent draft" reads as
1131+
// one concept, but muted rather than amber: on a thread row it's a
1132+
// quiet status flag, not a block asking for a decision. Matches the
1133+
// PR badge's settled treatment: muted at rest so the parked tail
1134+
// stays quiet, brightening with the row on hover. The glyph has no
1135+
// state colour of its own, so it lifts to the same foreground the
1136+
// title does.
11351137
"inline-flex shrink-0 items-center justify-center text-secondary-label",
11361138
!props.isActive && "transition-colors group-hover/v2-row:text-foreground",
11371139
)}
11381140
>
1139-
<PencilIcon className="size-3.5" />
1141+
<SquarePenIcon className="size-3.5" />
11401142
</span>
11411143
) : null;
11421144

0 commit comments

Comments
 (0)