Send props not defined on the route component in $attrs. Fixes #1695.

[lbogdan]

Fixes #1695.

[lbogdan]

Hm, any idea why is the test failing? It works on my machine™:

 √ Testing if element <li a> has count: 5
...
 √ Testing if the URL equals "http://localhost:8080/route-props/attrs".
 √ Testing if element <.hello> contains text: "Hello attrs".

[LinusBorg]

probably because nightwatch/phantomJS is a nightmre sometimes ...

someone with access to CircleCI can usually fix it by running it without caches.

[lbogdan]

Also, that test works locally, but this one (in test:types) doesn't:

types/test/index.ts(164,7): error TS2322: Type 'Component[]' is not assignable to type 'Component'.
  Type 'Component[]' is not assignable to type 'typeof Vue'.
    Property 'prototype' is missing in type 'Component[]'.

Which, if I look at the code, seems to be right:

const Components: ComponentOptions<Vue> | typeof Vue = router.getMatchedComponents();

(router.getMatchedComponents() should return Component[])

Strange?

[posva]

I rerun the tests

[lbogdan]

I see that my test passed, but as I said earlier, now test:types fails, even if my changes have nothing to do with TS code.

[lbogdan]

@LinusBorg @posva Any idea?

[posva]

@lbogdan No idea unfortunately 😞
@ktsn Could you take a look, whenever you can, at the error in circle ci and see how it could be related to the small modification made 🙏 (Sorry for the inconvenience and thank you very much)

[ktsn]

@posva
Looks like the type of Components variable in the test case is incorrect.

The router.getMatchedComponent() returns Component[] (alias of (ComponentOptions<Vue> | typeof Vue | AsyncComponent)[]) but it is annotated with ComponentOptions<Vue> | typeof Vue in the test case.

So replacing this line with the below would work.

const Components: (ComponentOptions<Vue> | typeof Vue)[] = router.getMatchedComponents();

[lbogdan]

@ktsn @posva Well, the test case is clearly incorrect, the question is why tests in other pull requests pass? 😄

[ktsn]

Looks like it's because typescript compiler version. TypeScript v2.4.0 passes the test cases but v2.4.2 doesn't. And the lockfile is updated recently. 76f6db9

[lbogdan]

@ktsn Makes sense, then. So, how should I proceed? Should I fix that in this PR?

[lbogdan]

Hm, still

vue-router/package-lock.json

Line 7485 in 6d4ac75

"version": "2.4.2",

uses typescript 2.4.2, and the tests pass https://circleci.com/gh/vuejs/vue-router/1570 .

[ktsn]

Maybe, it's because of CI cache?
I think we should fix the test case, anyway. I just made a PR for that. #1713

[lbogdan]

Ok, then I'll wait for it to be merged and rebase. Thanks!

[posva]

@lbogdan I merged #1713

[lbogdan]

Finally! 😄

[lbogdan]

Ping?

[posva]

ping @yyx990803

[lbogdan]

Any news on this?

[lbogdan]

"Is there anybody out there?" 😄