feat(prefer-describe-function-title): Check for unnecessary .name (#744)

* feat: report unnecessary `.name` usage in prefer-describe-function-title

* test: add tests

* refactor: use DefinitionType for  type checks

Author: y-hsgw

src/rules/prefer-describe-function-title.ts

@@ -1,4 +1,5 @@
-import { AST_NODE_TYPES, ESLintUtils, TSESLint } from '@typescript-eslint/utils'
+import { AST_NODE_TYPES, ESLintUtils } from '@typescript-eslint/utils'
+import { DefinitionType } from '@typescript-eslint/scope-manager'
 import { createEslintRule } from '../utils'
 import { parsePluginSettings } from '../utils/parse-plugin-settings'
 import { parseVitestFnCall } from '../utils/parse-vitest-fn-call'
@@ -32,7 +33,32 @@ export default createEslintRule<Options, MESSAGE_IDS>({
           return
         }
 
+        const scope = getModuleScope(context, node)
         const [argument] = node.arguments
+        if (
+          argument.type === AST_NODE_TYPES.MemberExpression &&
+          argument.object.type === AST_NODE_TYPES.Identifier &&
+          argument.property.type === AST_NODE_TYPES.Identifier
+        ) {
+          const identifierName = argument.object.name
+          const scopedFunction = scope?.set.get(identifierName)?.defs[0]
+          if (
+            scopedFunction?.type !== DefinitionType.ImportBinding ||
+            argument.property.name !== 'name'
+          ) {
+            return
+          }
+
+          context.report({
+            node: argument,
+            messageId: 'preferFunction',
+            fix(fixer) {
+              return fixer.replaceText(argument, identifierName)
+            },
+          })
+          return
+        }
+
         if (
           argument.type !== AST_NODE_TYPES.Literal ||
           typeof argument.value !== 'string'
@@ -50,9 +76,8 @@ export default createEslintRule<Options, MESSAGE_IDS>({
           return
         }
 
-        const scope = getModuleScope(context, node)
         const scopedFunction = scope?.set.get(describedTitle)?.defs[0]
-        if (scopedFunction?.type !== 'ImportBinding') {
+        if (scopedFunction?.type !== DefinitionType.ImportBinding) {
           return
         }
 

tests/prefer-describe-function-title.test.ts

@@ -75,6 +75,13 @@ ruleTester.run(RULE_NAME, rule, {
       `,
       filename: 'myFunction.test.ts',
     },
+    {
+      code: `
+        import { myFunction } from "./myFunction.js"
+        describe(otherFunction.name, () => {})
+      `,
+      filename: 'myFunction.test.ts',
+    },
     {
       code: `
         declare const myFunction: () => unknown
@@ -114,6 +121,25 @@ ruleTester.run(RULE_NAME, rule, {
         describe(myFunction, () => {})
       `,
     },
+    {
+      code: `
+        import { myFunction } from "./myFunction"
+        describe(myFunction.name, () => {})
+      `,
+      errors: [
+        {
+          column: 18,
+          endColumn: 33,
+          line: 3,
+          messageId: 'preferFunction',
+        },
+      ],
+      filename: 'myFunction.test.ts',
+      output: `
+        import { myFunction } from "./myFunction"
+        describe(myFunction, () => {})
+      `,
+    },
     {
       code: `
         import { myFunction } from "./myFunction"