Skip to content

Commit fe4ecf4

Browse files
committed
fix(ci): always run documentation commit on release
The `if` guard on the "Commit and push changes" step compared `github.ref` to `refs/heads/<default_branch>`, but the Release workflow triggers only on tag pushes (`on: push: tags: 'v*'`), so `github.ref` is always `refs/tags/vX.Y.Z` and never a branch ref — the condition can never be true. Before 36fa8b6 the guard used mixed `${{ }}` interpolation inside literal text, which GitHub Actions evaluates as a non-empty (truthy) string, so the step always ran (by accident). Rewriting it with `format()` turned it into a proper boolean that is always false on tag-triggered runs, silently skipping the documentation commit since v6.0.3. The job only runs on `v*` tag pushes (gated by build-release's repository guard) and the checkout already targets the default branch, so the guard is unnecessary. Remove it so the docs commit runs on every release.
1 parent 062b960 commit fe4ecf4

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

.github/workflows/release.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,6 @@ jobs:
131131
pnpm typedoc
132132
133133
- name: Commit and push changes
134-
if: ${{ github.ref == format('refs/heads/{0}', github.event.repository.default_branch) }}
135134
env:
136135
COMMIT_MESSAGE: 'docs: publish documentation'
137136
COMMIT_AUTHOR: Documentation Bot

0 commit comments

Comments
 (0)