Skip to content

Commit e4dc9d2

Browse files
committed
[NO UPSTREAM] buck2: drop elf_sections from the OSS build
Upstream embeds `buck2_miniperf` into `buck2-bin` as a compressed ELF section. The bootstrap build cannot do this: `[external_cells] prelude = bundled` takes the prelude from the pinned `bootstrap/buck2` snapshot, which predates the `elf_sections` attr, and there is no newer release to bump to. Nothing is lost: `MiniperfContainer::new` is `#[cfg(all(fbcode_build, target_os = "linux"))]` and returns `Ok(None)` otherwise, so an OSS buck2 never reads the section. Signed-off-by: Austin Seipp <aseipp@pobox.com>
1 parent b6e58f0 commit e4dc9d2

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

app/buck2/BUCK

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -101,12 +101,6 @@ buck_rust_binary(
101101
allow_cache_upload = True,
102102
crate = "buck2",
103103
crate_root = "bin/buck2.rs",
104-
elf_sections = select({
105-
"DEFAULT": {},
106-
"ovr_config//os:linux": {
107-
"buck2_miniperf": "//buck2/app/buck2_miniperf:embedded_section",
108-
},
109-
}),
110104
env = {
111105
# This is only set for release builds.
112106
"BUCK2_RELEASE_TIMESTAMP": read_config("buck", "release_timestamp", ""),

0 commit comments

Comments
 (0)