Skip to content

Commit 1d904c4

Browse files
singhpk234thomaschow
authored andcommitted
Core: Restrict visibility of spec-by-id API for scan planning responses (apache#14485)
1 parent ea2539e commit 1d904c4

4 files changed

Lines changed: 15 additions & 0 deletions

File tree

core/src/main/java/org/apache/iceberg/rest/responses/BaseScanTaskResponse.java

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,10 @@ public List<DeleteFile> deleteFiles() {
5555
return deleteFiles;
5656
}
5757

58+
/**
59+
* @deprecated since 1.11.0, visibility will be reduced in 1.12.0.
60+
*/
61+
@Deprecated
5862
public Map<Integer, PartitionSpec> specsById() {
5963
return specsById;
6064
}
@@ -87,6 +91,10 @@ public B withDeleteFiles(List<DeleteFile> deleteFilesList) {
8791
return self();
8892
}
8993

94+
/**
95+
* @deprecated since 1.11.0, visibility will be reduced in 1.12.0.
96+
*/
97+
@Deprecated
9098
public B withSpecsById(Map<Integer, PartitionSpec> specs) {
9199
this.specsById = specs;
92100
return self();
@@ -104,6 +112,10 @@ public List<DeleteFile> deleteFiles() {
104112
return deleteFiles;
105113
}
106114

115+
/**
116+
* @deprecated since 1.11.0, visibility will be reduced in 1.12.0.
117+
*/
118+
@Deprecated
107119
public Map<Integer, PartitionSpec> specsById() {
108120
return specsById;
109121
}

core/src/main/java/org/apache/iceberg/rest/responses/FetchPlanningResultResponseParser.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@ public static FetchPlanningResultResponse fromJson(
8787
.withPlanTasks(planTasks)
8888
.withFileScanTasks(fileScanTasks)
8989
.withDeleteFiles(deleteFiles)
90+
.withSpecsById(specsById)
9091
.build();
9192
}
9293
}

core/src/main/java/org/apache/iceberg/rest/responses/FetchScanTasksResponseParser.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ public static FetchScanTasksResponse fromJson(
7777
TableScanResponseParser.parseFileScanTasks(json, deleteFiles, specsById, caseSensitive);
7878
return FetchScanTasksResponse.builder()
7979
.withPlanTasks(planTasks)
80+
.withSpecsById(specsById)
8081
.withFileScanTasks(fileScanTasks)
8182
.withDeleteFiles(deleteFiles)
8283
.build();

core/src/main/java/org/apache/iceberg/rest/responses/PlanTableScanResponseParser.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ public static PlanTableScanResponse fromJson(
9898
.withPlanTasks(planTasks)
9999
.withFileScanTasks(fileScanTasks)
100100
.withDeleteFiles(deleteFiles)
101+
.withSpecsById(specsById)
101102
.build();
102103
}
103104
}

0 commit comments

Comments
 (0)