Skip to content

Commit eabf603

Browse files
committed
Add note about unset
1 parent 4637b48 commit eabf603

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

main.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -494,6 +494,8 @@ token="${GITHUB_TOKEN:-"${GH_TOKEN:-"${DEFAULT_GITHUB_TOKEN:-}"}"}"
494494
# This prevents tokens from being exposed to subprocesses via environment variables.
495495
# Since the tokens remain in memory, setting `fallback: none` (which prevents the tokens from being
496496
# set in the first place) remains the best practice from a security standpoint, as readme says.
497+
# Note that this does not prevent token leaks via reading `/proc/*/environ` on Linux or
498+
# via `ps -Eww` on macOS. It only reduces the risk of leaks.
497499
unset GITHUB_TOKEN GH_TOKEN DEFAULT_GITHUB_TOKEN
498500

499501
# Refs: https://github.com/rust-lang/rustup/blob/HEAD/rustup-init.sh

0 commit comments

Comments
 (0)