Merge pull request #225 from byte-bandit/master

feat: add support for special characters in path

Author: vearutop

chirouter/example_test.go

@@ -45,13 +45,14 @@ func ExamplePathToURLValues() {
 
 	// Serving example URL.
 	w := httptest.NewRecorder()
-	req, _ := http.NewRequest(http.MethodPost, "/foo/abc/bar/123?query1=321",
+
+	req, _ := http.NewRequest(http.MethodPost, `/foo/a%2Fbc/bar/123?query1=321`,
 		bytes.NewBufferString("formData1=true&formData2=def"))
 
 	req.Header.Set("Content-Type", "application/x-www-form-urlencoded")
 	req.Header.Set("X-Header-1", "1.23")
 
 	router.ServeHTTP(w, req)
 	// Output:
-	// {Query1:321 Path1:abc Path2:123 Header1:1.23 FormData1:true FormData2:def}
+	// {Query1:321 Path1:a/bc Path2:123 Header1:1.23 FormData1:true FormData2:def}
 }

chirouter/path_decoder.go

@@ -1,19 +1,26 @@
 package chirouter
 
 import (
+	"fmt"
 	"net/http"
 	"net/url"
 
 	"github.com/go-chi/chi/v5"
 )
 
 // PathToURLValues is a decoder function for parameters in path.
-func PathToURLValues(r *http.Request) (url.Values, error) { //nolint:unparam // Matches request.DecoderFactory.SetDecoderFunc.
+func PathToURLValues(r *http.Request) (url.Values, error) {
 	if routeCtx := chi.RouteContext(r.Context()); routeCtx != nil {
 		params := make(url.Values, len(routeCtx.URLParams.Keys))
 
 		for i, key := range routeCtx.URLParams.Keys {
 			value := routeCtx.URLParams.Values[i]
+
+			value, err := url.PathUnescape(value)
+			if err != nil {
+				return nil, fmt.Errorf("unescaping path: %w", err)
+			}
+
 			params[key] = []string{value}
 		}