Merge pull request #304 from seq-code/names-regression

Fix regression on /names/user returning empty list

Author: lmrodriguezr

app/controllers/concerns/name_filterable.rb

@@ -23,6 +23,8 @@ def name_status_filters
     # @return [Integer, Array<Integer>] The status value(s).
     def map_status_to_value(status)
       status = status.to_s.downcase
+      return nil if status == 'all'
+
       status = 'icnafp' if status == 'icn'
       name_status_filters[status] || status
     end

test/controllers/names_controller_test.rb

@@ -21,4 +21,11 @@ class NamesControllerTest < ActionDispatch::IntegrationTest
     assert name.observing?(@user)
     assert_redirected_to name_url(name)
   end
+
+  test 'user names includes draft names' do
+    get user_names_url
+
+    assert_response :success
+    assert_includes @response.body, names(:draft_by_contributor).name
+  end
 end

test/fixtures/names.yml

@@ -3,6 +3,11 @@
 unregistered:
   name: MyString
 
+draft_by_contributor:
+  name: Testimonas draftensis
+  status: 5 # draft
+  created_by: contributor
+
 escherichia:
   name: Escherichia
   rank: genus