From 9e7c12161e2a0253914fd214a2536f15f5c21409 Mon Sep 17 00:00:00 2001 From: Matheus Mendes Date: Tue, 31 Oct 2017 19:59:32 -0200 Subject: [PATCH] Add Code Review section into Contributing.md --- CONTRIBUTING.md | 6 ++++++ README.md | 1 + 2 files changed, 7 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index cc48269d..3431b33d 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -9,6 +9,7 @@ Hello! Thank you for choosing to help contribute to one of the SendGrid open sou - [Testing](#testing) - [Style Guidelines & Naming Conventions](#style-guidelines-and-naming-conventions) - [Creating a Pull Request](#creating-a-pull-request) +- [Code Reviews][#Code-Reviews] We use [Milestones](https://github.com/sendgrid/sendgrid-java/milestones) to help define current roadmaps, please feel free to grab an issue from the current milestone. Please indicate that you have begun work on it to avoid collisions. Once a PR is made, community review, comments, suggestions and additional PRs are welcomed and encouraged. @@ -214,3 +215,8 @@ Please run your code through: with a clear title and description against the `master` branch. All tests must be passing before we will review the PR. If you have any additional questions, please feel free to [email](mailto:dx@sendgrid.com) us or create an issue in this repo. + + +## Code Reviews + +If you can, please look at open PRs and review them. Give feedback and help us merge these PRs much faster! If you don't know how, Github has some great [information on how to review a Pull Request.](https://help.github.com/articles/about-pull-request-reviews/) diff --git a/README.md b/README.md index 5d582daf..c5416785 100644 --- a/README.md +++ b/README.md @@ -220,6 +220,7 @@ Quick links: - [Bug Reports](https://github.com/sendgrid/sendgrid-java/blob/master/CONTRIBUTING.md#submit-a-bug-report) - [Sign the CLA to Create a Pull Request](https://github.com/sendgrid/sendgrid-java/blob/master/CONTRIBUTING.md#cla) - [Improvements to the Codebase](https://github.com/sendgrid/sendgrid-java/blob/master/CONTRIBUTING.md#improvements-to-the-codebase) +- [Review Pull Requests](https://github.com/sendgrid/sendgrid-java/issues/CONTRIBUTING.md#Code-Reviews) # Troubleshooting