[Fix #1595] Fix a false negative for Rails/I18nLocaleTexts when using redirect_back_or_to

Author: 55728

changelog/fix_i18n_locale_texts_redirect_back_or_to.md

@@ -0,0 +1 @@
+* [#1595](https://github.com/rubocop/rubocop-rails/issues/1595): Fix a false negative for `Rails/I18nLocaleTexts` when using `redirect_back_or_to` with a flash message. ([@55728][])

lib/rubocop/cop/rails/i18n_locale_texts.rb

@@ -47,6 +47,28 @@ module Rails
       #   end
       #
       #   # bad
+      #   class PostsController < ApplicationController
+      #     def update
+      #       # ...
+      #       redirect_back_or_to root_path, alert: "Failed to update!"
+      #     end
+      #   end
+      #
+      #   # good
+      #   # config/locales/en.yml
+      #   # en:
+      #   #   posts:
+      #   #     update:
+      #   #       failure: "Failed to update!"
+      #
+      #   class PostsController < ApplicationController
+      #     def update
+      #       # ...
+      #       redirect_back_or_to root_path, alert: t(".failure")
+      #     end
+      #   end
+      #
+      #   # bad
       #   class UserMailer < ApplicationMailer
       #     def welcome(user)
       #       mail(to: user.email, subject: "Welcome to My Awesome Site")
@@ -69,7 +91,7 @@ module Rails
       class I18nLocaleTexts < Base
         MSG = 'Move locale texts to the locale files in the `config/locales` directory.'
 
-        RESTRICT_ON_SEND = %i[validates redirect_to redirect_back []= mail].freeze
+        RESTRICT_ON_SEND = %i[validates redirect_to redirect_back redirect_back_or_to []= mail].freeze
 
         def_node_search :validation_message, <<~PATTERN
           (pair (sym :message) $str)
@@ -98,7 +120,7 @@ def on_send(node)
               add_offense(text_node)
             end
             return
-          when :redirect_to, :redirect_back
+          when :redirect_to, :redirect_back, :redirect_back_or_to
             text_node = redirect_to_flash(node).to_a.last
           when :[]=
             text_node = flash_assignment?(node)

spec/rubocop/cop/rails/i18n_locale_texts_spec.rb

@@ -33,6 +33,26 @@
     RUBY
   end
 
+  it 'registers an offense when using `redirect_back_or_to` with a notice text message' do
+    expect_offense(<<~RUBY)
+      redirect_back_or_to root_path, notice: "Post created!"
+                                             ^^^^^^^^^^^^^^^ Move locale texts to the locale files in the `config/locales` directory.
+    RUBY
+  end
+
+  it 'registers an offense when using `redirect_back_or_to` with an alert text message' do
+    expect_offense(<<~RUBY)
+      redirect_back_or_to root_path, alert: "Failed to update!"
+                                            ^^^^^^^^^^^^^^^^^^^ Move locale texts to the locale files in the `config/locales` directory.
+    RUBY
+  end
+
+  it 'does not register an offense when using `redirect_back_or_to` with localized flash messages' do
+    expect_no_offenses(<<~RUBY)
+      redirect_back_or_to root_path, notice: t(".success")
+    RUBY
+  end
+
   it 'does not register an offense when using `redirect_to` with localized flash messages' do
     expect_no_offenses(<<~RUBY)
       redirect_to root_path, notice: t(".success")