Merge pull request #9426 from tejasbubane/fix-9425

[Fix #9425] Fix error in `Layout/ClassStructure` when initializer comes after private attribute macro

Author: koic

changelog/fix_error_in_layout_class_structure.md

@@ -0,0 +1 @@
+* [#9425](https://github.com/rubocop-hq/rubocop/issues/9425): Fix error in `Layout/ClassStructure` when initializer comes after private attribute macro. ([@tejasbubane][])

lib/rubocop/cop/layout/class_structure.rb

@@ -269,7 +269,7 @@ def humanize_node(node)
 
         def source_range_with_comment(node)
           begin_pos, end_pos =
-            if node.def_type? || node.send_type? && node.def_modifier?
+            if node.def_type? && !node.method?(:initialize) || node.send_type? && node.def_modifier?
               start_node = find_visibility_start(node) || node
               end_node = find_visibility_end(node) || node
               [begin_pos_with_comment(start_node),

spec/rubocop/cop/layout/class_structure_spec.rb

@@ -366,4 +366,31 @@ def bar
       RUBY
     end
   end
+
+  context 'initializer is private and comes after attribute macro' do
+    it 'registers offense and auto-corrects' do
+      expect_offense(<<~RUBY)
+        class A
+          private
+
+          attr_accessor :foo
+
+          def initialize
+          ^^^^^^^^^^^^^^ `initializer` is supposed to appear before `private_attribute_macros`.
+          end
+        end
+      RUBY
+
+      expect_correction(<<~RUBY)
+        class A
+          private
+
+          def initialize
+          end
+          attr_accessor :foo
+
+        end
+      RUBY
+    end
+  end
 end