Fix compiler warnings for 1.20.0-rc.2

Author: rrrene

lib/credo/check/readability/nested_function_calls.ex

@@ -348,10 +348,10 @@ defmodule Credo.Check.Readability.NestedFunctionCalls do
     defp argument_type({:{}, _, _}), do: [:tuple]
     defp argument_type(nil), do: []
 
+    defp argument_type(v) when is_boolean(v), do: [:boolean]
     defp argument_type(v) when is_atom(v), do: [:atom]
     defp argument_type(v) when is_binary(v), do: [:binary]
     defp argument_type(v) when is_bitstring(v), do: [:bitstring]
-    defp argument_type(v) when is_boolean(v), do: [:boolean]
 
     defp argument_type(v) when is_list(v) do
       if Keyword.keyword?(v) do

lib/credo/check/refactor/pipe_chain_start.ex

@@ -278,10 +278,10 @@ defmodule Credo.Check.Refactor.PipeChainStart do
   defp argument_type({:{}, _, _}), do: [:tuple]
   defp argument_type(nil), do: []
 
+  defp argument_type(v) when is_boolean(v), do: [:boolean]
   defp argument_type(v) when is_atom(v), do: [:atom]
   defp argument_type(v) when is_binary(v), do: [:binary]
   defp argument_type(v) when is_bitstring(v), do: [:bitstring]
-  defp argument_type(v) when is_boolean(v), do: [:boolean]
 
   defp argument_type(v) when is_list(v) do
     if Keyword.keyword?(v) do

lib/credo/cli/command/diff/diff_command.ex

@@ -59,12 +59,10 @@ defmodule Credo.CLI.Command.Diff.DiffCommand do
   def previous_ref(exec) do
     case exec.cli_options.switches do
       %{since: given_datetime} ->
-        previous_ref_as_datetime(given_datetime) ||
-          {:error, "given value is not a valid commit date: #{given_datetime}"}
+        previous_ref_as_datetime(given_datetime)
 
       %{from_dir: given_dir} ->
-        previous_ref_as_path(given_dir) ||
-          {:error, "given value is not a local directory: #{given_dir}"}
+        previous_ref_as_path(given_dir)
 
       %{from_git_ref: given_git_ref} ->
         previous_ref_as_git_ref(given_git_ref) ||

lib/credo/execution.ex

@@ -233,9 +233,6 @@ defmodule Credo.Execution do
   defp filter_ignore_checks_by_tags(_checks, []), do: []
   defp filter_ignore_checks_by_tags(checks, tags), do: filter_checks_by_tags(checks, tags)
 
-  defp filter_checks_by_tags(_checks, nil), do: []
-  defp filter_checks_by_tags(_checks, []), do: []
-
   defp filter_checks_by_tags(checks, tags) do
     tags = Enum.map(tags, &String.to_atom/1)