Skip to content

Commit 96316a6

Browse files
authored
fix(debugging): stop debugger displays rendering as a bare null (#2315)
- Give every debugger display literal text alongside its placeholder. A display made of nothing but one member rendered as a bare `null` the moment that member was null, which reads as though the object itself does not exist. - ApiResponse<T> was the reported case: hovering a response that came back without content showed `null`, sending the reader looking for a NullReferenceException that was never thrown. It now leads with the type and the status code. - Ten other shipped types carried the same shape and are fixed with it. - Add DebuggerDisplayTests, which walks the shipped assemblies and fails any display whose sole placeholder can be null, plus any placeholder naming a member that does not exist. Closes #2313
1 parent 1643323 commit 96316a6

52 files changed

Lines changed: 293 additions & 121 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

src/Refit.HttpClientFactory/PublicAPI/net10.0/PublicAPI.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ public interface ISettingsFor
121121
{
122122
Refit.RefitSettings? Settings { get; }
123123
}
124-
[System.Diagnostics.DebuggerDisplay("{Settings}")]
124+
[System.Diagnostics.DebuggerDisplay("SettingsFor: {Settings}")]
125125
public class SettingsFor<T> : Refit.ISettingsFor
126126
{
127127
public SettingsFor(Refit.RefitSettings? settings) { }

src/Refit.HttpClientFactory/PublicAPI/net11.0/PublicAPI.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ public interface ISettingsFor
121121
{
122122
Refit.RefitSettings? Settings { get; }
123123
}
124-
[System.Diagnostics.DebuggerDisplay("{Settings}")]
124+
[System.Diagnostics.DebuggerDisplay("SettingsFor: {Settings}")]
125125
public class SettingsFor<T> : Refit.ISettingsFor
126126
{
127127
public SettingsFor(Refit.RefitSettings? settings) { }

src/Refit.HttpClientFactory/PublicAPI/net462/PublicAPI.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public interface ISettingsFor
5757
{
5858
Refit.RefitSettings? Settings { get; }
5959
}
60-
[System.Diagnostics.DebuggerDisplay("{Settings}")]
60+
[System.Diagnostics.DebuggerDisplay("SettingsFor: {Settings}")]
6161
public class SettingsFor<T> : Refit.ISettingsFor
6262
{
6363
public SettingsFor(Refit.RefitSettings? settings) { }

src/Refit.HttpClientFactory/PublicAPI/net470/PublicAPI.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public interface ISettingsFor
5757
{
5858
Refit.RefitSettings? Settings { get; }
5959
}
60-
[System.Diagnostics.DebuggerDisplay("{Settings}")]
60+
[System.Diagnostics.DebuggerDisplay("SettingsFor: {Settings}")]
6161
public class SettingsFor<T> : Refit.ISettingsFor
6262
{
6363
public SettingsFor(Refit.RefitSettings? settings) { }

src/Refit.HttpClientFactory/PublicAPI/net471/PublicAPI.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public interface ISettingsFor
5757
{
5858
Refit.RefitSettings? Settings { get; }
5959
}
60-
[System.Diagnostics.DebuggerDisplay("{Settings}")]
60+
[System.Diagnostics.DebuggerDisplay("SettingsFor: {Settings}")]
6161
public class SettingsFor<T> : Refit.ISettingsFor
6262
{
6363
public SettingsFor(Refit.RefitSettings? settings) { }

src/Refit.HttpClientFactory/PublicAPI/net472/PublicAPI.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public interface ISettingsFor
5757
{
5858
Refit.RefitSettings? Settings { get; }
5959
}
60-
[System.Diagnostics.DebuggerDisplay("{Settings}")]
60+
[System.Diagnostics.DebuggerDisplay("SettingsFor: {Settings}")]
6161
public class SettingsFor<T> : Refit.ISettingsFor
6262
{
6363
public SettingsFor(Refit.RefitSettings? settings) { }

src/Refit.HttpClientFactory/PublicAPI/net48/PublicAPI.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public interface ISettingsFor
5757
{
5858
Refit.RefitSettings? Settings { get; }
5959
}
60-
[System.Diagnostics.DebuggerDisplay("{Settings}")]
60+
[System.Diagnostics.DebuggerDisplay("SettingsFor: {Settings}")]
6161
public class SettingsFor<T> : Refit.ISettingsFor
6262
{
6363
public SettingsFor(Refit.RefitSettings? settings) { }

src/Refit.HttpClientFactory/PublicAPI/net481/PublicAPI.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public interface ISettingsFor
5757
{
5858
Refit.RefitSettings? Settings { get; }
5959
}
60-
[System.Diagnostics.DebuggerDisplay("{Settings}")]
60+
[System.Diagnostics.DebuggerDisplay("SettingsFor: {Settings}")]
6161
public class SettingsFor<T> : Refit.ISettingsFor
6262
{
6363
public SettingsFor(Refit.RefitSettings? settings) { }

src/Refit.HttpClientFactory/PublicAPI/net8.0/PublicAPI.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ public interface ISettingsFor
105105
{
106106
Refit.RefitSettings? Settings { get; }
107107
}
108-
[System.Diagnostics.DebuggerDisplay("{Settings}")]
108+
[System.Diagnostics.DebuggerDisplay("SettingsFor: {Settings}")]
109109
public class SettingsFor<T> : Refit.ISettingsFor
110110
{
111111
public SettingsFor(Refit.RefitSettings? settings) { }

src/Refit.HttpClientFactory/PublicAPI/net9.0/PublicAPI.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ public interface ISettingsFor
121121
{
122122
Refit.RefitSettings? Settings { get; }
123123
}
124-
[System.Diagnostics.DebuggerDisplay("{Settings}")]
124+
[System.Diagnostics.DebuggerDisplay("SettingsFor: {Settings}")]
125125
public class SettingsFor<T> : Refit.ISettingsFor
126126
{
127127
public SettingsFor(Refit.RefitSettings? settings) { }

0 commit comments

Comments
 (0)