Commit 36ded71
committed
Fix nodeName to UPPERCASE in insertStylesheetIntoRoot (#28255)
## Summary
<!--
Explain the **motivation** for making this change. What existing problem
does the pull request solve?
-->
<img width="518" alt="image"
src="https://github.com/facebook/react/assets/18693190/6d12df76-7dae-403b-b486-4940992abe8d">
The condition `node.nodeName === 'link'` is always `false`, because
`node.nodeName` is Uppercase in specification. And the condition
`node.nodeName === 'LINK'` is unnecessary, because Fizz hoists tags when
it's `media` attribute is `"not all"`, whether it is a `link` or a
`style` (line 36):
https://github.com/facebook/react/blob/18cbcbf783377c5a22277a63ae41af54504502e0/packages/react-dom-bindings/src/server/fizz-instruction-set/ReactDOMFizzInstructionSetExternalRuntime.js#L30-L44
https://github.com/facebook/react/blob/18cbcbf783377c5a22277a63ae41af54504502e0/packages/react-dom-bindings/src/server/fizz-instruction-set/ReactDOMFizzInstructionSetInlineSource.js#L30-L44
DiffTrain build for [b75cc07](b75cc07)1 parent a2485b7 commit 36ded71
34 files changed
Lines changed: 190 additions & 201 deletions
File tree
- compiled/facebook-www
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2001 | 2001 | | |
2002 | 2002 | | |
2003 | 2003 | | |
2004 | | - | |
| 2004 | + | |
2005 | 2005 | | |
2006 | 2006 | | |
2007 | 2007 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1981 | 1981 | | |
1982 | 1982 | | |
1983 | 1983 | | |
1984 | | - | |
| 1984 | + | |
1985 | 1985 | | |
1986 | 1986 | | |
1987 | 1987 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
665 | 665 | | |
666 | 666 | | |
667 | 667 | | |
668 | | - | |
| 668 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
665 | 665 | | |
666 | 666 | | |
667 | 667 | | |
668 | | - | |
| 668 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
669 | 669 | | |
670 | 670 | | |
671 | 671 | | |
672 | | - | |
| 672 | + | |
673 | 673 | | |
674 | 674 | | |
675 | 675 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
669 | 669 | | |
670 | 670 | | |
671 | 671 | | |
672 | | - | |
| 672 | + | |
673 | 673 | | |
674 | 674 | | |
675 | 675 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17121 | 17121 | | |
17122 | 17122 | | |
17123 | 17123 | | |
17124 | | - | |
| 17124 | + | |
17125 | 17125 | | |
17126 | 17126 | | |
17127 | 17127 | | |
17128 | | - | |
| 17128 | + | |
17129 | 17129 | | |
17130 | 17130 | | |
17131 | 17131 | | |
| |||
17159 | 17159 | | |
17160 | 17160 | | |
17161 | 17161 | | |
17162 | | - | |
| 17162 | + | |
17163 | 17163 | | |
17164 | 17164 | | |
17165 | 17165 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16567 | 16567 | | |
16568 | 16568 | | |
16569 | 16569 | | |
16570 | | - | |
| 16570 | + | |
16571 | 16571 | | |
16572 | 16572 | | |
16573 | 16573 | | |
16574 | | - | |
| 16574 | + | |
16575 | 16575 | | |
16576 | 16576 | | |
16577 | 16577 | | |
| |||
16605 | 16605 | | |
16606 | 16606 | | |
16607 | 16607 | | |
16608 | | - | |
| 16608 | + | |
16609 | 16609 | | |
16610 | 16610 | | |
16611 | 16611 | | |
| |||
0 commit comments