Skip to content

Add a GitHub Action that runs the build script#7861

Merged
iansu merged 1 commit into
react:masterfrom
iansu:github-action-build
Oct 22, 2019
Merged

Add a GitHub Action that runs the build script#7861
iansu merged 1 commit into
react:masterfrom
iansu:github-action-build

Conversation

@iansu

@iansu iansu commented Oct 22, 2019

Copy link
Copy Markdown
Contributor

This is a just a quick experiment with GitHub Actions.

I realize that this particular action is not useful at all. See #7852.

@iansu iansu added this to the 3.3 milestone Oct 22, 2019
@iansu

iansu commented Oct 22, 2019

Copy link
Copy Markdown
Contributor Author

This check succeeded on my fork so I'm going to merge it.

@iansu iansu merged commit 9788522 into react:master Oct 22, 2019
@iansu iansu deleted the github-action-build branch October 22, 2019 02:08
@ghost ghost mentioned this pull request Oct 22, 2019
@lock lock Bot locked and limited conversation to collaborators Oct 27, 2019
@gaearon

gaearon commented Nov 8, 2019

Copy link
Copy Markdown
Contributor

FYI, there's going to be a snag with Actions after November 13 due to a planned change. They won't work for this repo until some time later (hopefully not too long after).

@iansu

iansu commented Nov 8, 2019

Copy link
Copy Markdown
Contributor Author

I'm curious to know more about that but good to know anyway. We are planning to use GitHub Actions more in the future but we'll hold off for now.

@gaearon

gaearon commented Nov 8, 2019

Copy link
Copy Markdown
Contributor

The tldr is it's just a contract thing we need to renew and it'll take a bit

@iansu

iansu commented Nov 8, 2019

Copy link
Copy Markdown
Contributor Author

Interesting. Thanks for sharing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants