feat(Keyboard): pre-load keyboards#538
Merged
Merged
Conversation
cee-money
requested review from
ImCoolNowRight,
anthony9187,
ctoddy,
erautenberg,
joshhowenstine and
soumyaloka
as code owners
September 17, 2024 16:07
|
|
Collaborator
|
Test Execution Passed. |
1 similar comment
Collaborator
|
Test Execution Passed. |
This comment was marked as resolved.
This comment was marked as resolved.
cee-money
force-pushed
the
feat/preload-keyboards
branch
from
September 17, 2024 20:44
abc5a74 to
9ae30b0
Compare
Collaborator
|
Test Execution Passed. |
cee-money
force-pushed
the
feat/preload-keyboards
branch
from
September 18, 2024 15:41
9ae30b0 to
5320331
Compare
Collaborator
|
Test Execution Passed. |
cee-money
changed the title
Collaborator
|
Test Execution Passed. |
ImCoolNowRight
approved these changes
Sep 19, 2024
ImCoolNowRight
left a comment
ImCoolNowRight
left a comment
Contributor
There was a problem hiding this comment.
Everything looks great!
Collaborator
|
Test Execution Passed. |
joshhowenstine
approved these changes
Sep 19, 2024
Collaborator
|
Test Execution Passed. |
ImCoolNowRight
approved these changes
Sep 19, 2024
svc-lightning-ui-components
pushed a commit
that referenced
this pull request
Sep 19, 2024
# [@lightningjs/ui-components-v2.22.0](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-v2.21.9...@lightningjs/ui-components-v2.22.0) (2024-09-19) ### Bug Fixes * **ControlRow:** allow items to be added if contentItems is empty ([#531](#531)) ([0b1323f](0b1323f)) * **MetadataCardContent:** expose subtitle property ([#537](#537)) ([d1ac54a](d1ac54a)) * **metadataCardContent:** Provider covers text after decrementing value ([#532](#532)) ([0792267](0792267)) ### Features * **InlineContent:** Font Strikethrough ([#535](#535)) ([108266e](108266e)) * **Keyboard:** pre-load keyboards ([#538](#538)) ([0016708](0016708)) * **ScrollWrapper:** add signals for button press at top and bottom of content ([#533](#533)) ([a914066](a914066))
Collaborator
|
🎉 This PR is included in version @lightningjs/ui-components-v2.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR creates and renders a keyboard associated with all formats and does so 1x in the update lifecycle event. All keyboards but the current are rendered yet hidden with a transparent alpha. This allows for toggling between formats to be more snappy since the requested format isn't being created & rendered on press but rather already exists.
_update_formatKeysremoved because no longer needed - keys are formatted on keyboard creationformatsdidn't update the formatsReferences
LUI-855
Testing
Created a deployment with these keyboard updates for testing: https://carolyn-lng-ephemeral.glitch.me
Test overall performance, load time, load time on format toggle, feel free to test on STB, etc.
Note, deployment uses:
Automation
Checklist