feat(InlineContent): Font Strikethrough#535
Merged
Merged
Conversation
shanteaustin
requested review from
ImCoolNowRight,
anthony9187,
cee-money,
ctoddy,
erautenberg,
joshhowenstine and
soumyaloka
as code owners
September 12, 2024 19:40
shanteaustin
changed the title
Collaborator
|
Test Execution Passed. |
cee-money
reviewed
Sep 12, 2024
cee-money
reviewed
Sep 12, 2024
Collaborator
|
Test Execution Passed. |
Collaborator
|
Test Execution Passed. |
1 similar comment
Collaborator
|
Test Execution Passed. |
cee-money
reviewed
Sep 16, 2024
cee-money
reviewed
Sep 16, 2024
anthony9187
reviewed
Sep 16, 2024
Collaborator
|
Test Execution Passed. |
Collaborator
|
Test Execution Passed. |
Collaborator
|
Test Execution Passed. |
ImCoolNowRight
left a comment
ImCoolNowRight
left a comment
Contributor
There was a problem hiding this comment.
Just need to remove that extra space in the story, and then I think this will be good to go! I'm ok with circling back once we hear back about how to handle the announcer.
Collaborator
|
Test Execution Passed. |
Contributor
Author
I thought that was remove looks like it was reverted so I updated it again. |
Collaborator
|
Test Execution Passed. |
ImCoolNowRight
approved these changes
Sep 18, 2024
Collaborator
|
Test Execution Passed. |
svc-lightning-ui-components
pushed a commit
that referenced
this pull request
Sep 19, 2024
# [@lightningjs/ui-components-v2.22.0](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-v2.21.9...@lightningjs/ui-components-v2.22.0) (2024-09-19) ### Bug Fixes * **ControlRow:** allow items to be added if contentItems is empty ([#531](#531)) ([0b1323f](0b1323f)) * **MetadataCardContent:** expose subtitle property ([#537](#537)) ([d1ac54a](d1ac54a)) * **metadataCardContent:** Provider covers text after decrementing value ([#532](#532)) ([0792267](0792267)) ### Features * **InlineContent:** Font Strikethrough ([#535](#535)) ([108266e](108266e)) * **Keyboard:** pre-load keyboards ([#538](#538)) ([0016708](0016708)) * **ScrollWrapper:** add signals for button press at top and bottom of content ([#533](#533)) ([a914066](a914066))
Collaborator
|
🎉 This PR is included in version @lightningjs/ui-components-v2.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated text styles to include an option to strike through
Testing
Go to Inline Content --> With Strike Through
To view line through text
Checklist