fix(KeyboardNumbers): move delete key up one row#526
Merged
Conversation
ImCoolNowRight
requested review from
THoj13,
anthony9187,
erautenberg,
joshhowenstine and
slhay28
as code owners
August 21, 2024 14:22
Collaborator
|
Test Execution Passed. |
cee-money
approved these changes
Aug 21, 2024
cee-money
left a comment
cee-money
left a comment
Contributor
There was a problem hiding this comment.
LGTM ✅
we used this exact dialpad layout in XG!
anthony9187
approved these changes
Aug 22, 2024
svc-lightning-ui-components
pushed a commit
that referenced
this pull request
Aug 26, 2024
# [@lightningjs/ui-components-v2.21.9](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-v2.21.8...@lightningjs/ui-components-v2.21.9) (2024-08-26) ### Bug Fixes * **docs:** clean up links in docs ([#525](#525)) ([682ea31](682ea31)) * **Hyperlinks:** links navigate to correct paths ([#524](#524)) ([a46dc62](a46dc62)) * **KeyboardNumbers:** move delete key up one row ([#526](#526)) ([2668bf1](2668bf1))
Collaborator
|
🎉 This PR is included in version @lightningjs/ui-components-v2.21.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves the Delete key up to be in the same row as the 0 key.
References
N/A
Testing
Ensure that the Delete key spans the width of two standard keys and is in the same row as the 0 key when the KeyboardNumbers story is set to use the dialpadExtended
defaultFormat.Automation
N/A
Checklist