fix: allow withEditItems to work with lazyScroll#496
Merged
Conversation
joshhowenstine
requested review from
ImCoolNowRight,
THoj13,
anthony9187,
arwehrman,
erautenberg,
jazzyw,
slhay28 and
soumyaloka
as code owners
March 27, 2024 01:10
Collaborator
|
Test Execution Passed. |
1 similar comment
Collaborator
|
Test Execution Passed. |
erautenberg
approved these changes
Apr 15, 2024
ImCoolNowRight
force-pushed
the
fix/with-edit-items-lazy-scroll
branch
from
October 30, 2024 14:04
22eb8ab to
6942063
Compare
svc-lightning-ui-components
pushed a commit
that referenced
this pull request
Oct 30, 2024
# [@lightningjs/ui-components-v2.25.0](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-v2.24.0...@lightningjs/ui-components-v2.25.0) (2024-10-30) ### Bug Fixes * allow withEditItems to work with lazyScroll ([#496](#496)) ([0cf0522](0cf0522)) ### Features * allow surface class radius to be overwritten by parent ([#548](#548)) ([3db0c5c](3db0c5c))
Collaborator
|
🎉 This PR is included in version @lightningjs/ui-components-v2.25.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An issue was discovered where withEditItems does not integrate smoothly with lazyScroll. This update ensures that the scrolling functionality will pause until the initial item swap transition is complete, thereby preventing any conflict or unexpected behavior during additional logic execution.
Ticket
Testing Instructions