Commit d75a240
Correct WORKFLOW.md audit flow and NUGET_USERNAME secret store (#422)
Fixes both items in #421, surfaced by Copilot review on #420.
## 1. `configure.sh check` / `apply` do not exist
`WORKFLOW.md` referenced subcommands the script never implemented. Its
interface is `[owner/repo] [release|operational]`, so `configure.sh
check` parses `check` as a **repository name** -- it acts on the wrong
target rather than erroring, which is why this was worth fixing rather
than leaving.
Auditing also moved to [`AUDIT.md`](../blob/develop/AUDIT.md) as a
read-only procedure; `configure.sh` now only applies. Updated:
- **5D Configuration audit** -- points at the AUDIT.md procedure
- **Validation** (section 6) -- AUDIT.md audits read-only, `configure.sh
[owner/repo] [release|operational]` applies
- Two residual phrases that still described the script as the auditor
("applied and audited by an idempotent `gh api` script", "the script
flags it as a manual verification item")
## 2. `NUGET_USERNAME` secret store
`WORKFLOW.md` said Actions-store-only; `spec/secrets.json` and
`AUDIT.md` say both stores. Resolved in favor of both, on two pieces of
evidence:
- The fleet hub's canonical `nuget-oidc` mechanism in
`ProjectTemplate/spec/secrets.json` declares `"stores": ["actions",
"dependabot"]`, and this repo's spec is a carry of it
- Live repository state has the name in both stores
```
actions: CODECOV_TOKEN CODEGEN_APP_CLIENT_ID CODEGEN_APP_PRIVATE_KEY NUGET_USERNAME
dependabot: CODECOV_TOKEN CODEGEN_APP_CLIENT_ID CODEGEN_APP_PRIVATE_KEY NUGET_USERNAME
```
So `WORKFLOW.md` was the outlier. It now states both stores and cites
the spec it follows.
Worth recording: Copilot predicted this would make the self-audit report
a false defect. It would not -- the secret is present in both stores, so
the audit passes today. The defect was purely that three documents
disagreed.
## Correction to the issue's fleet note
#421 speculated these might need upstream fixes too. Checked, and they
do not: ProjectTemplate's `WORKFLOW.md` has no `configure.sh` subcommand
references and no NuGet publish at all. Both drifts are local to this
repo.
## Verification
- No `configure.sh check|apply` references remain
- All three link targets resolve (`AUDIT.md`, `spec/secrets.json`,
`repo-config/configure.sh`)
- CRLF preserved; docs-only, no shipped input, so no release impact
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent a46e3cd commit d75a240
1 file changed
Lines changed: 16 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
586 | 586 | | |
587 | 587 | | |
588 | 588 | | |
589 | | - | |
| 589 | + | |
590 | 590 | | |
591 | | - | |
592 | | - | |
| 591 | + | |
| 592 | + | |
593 | 593 | | |
594 | 594 | | |
595 | | - | |
596 | | - | |
| 595 | + | |
| 596 | + | |
597 | 597 | | |
598 | 598 | | |
599 | 599 | | |
| |||
619 | 619 | | |
620 | 620 | | |
621 | 621 | | |
622 | | - | |
| 622 | + | |
| 623 | + | |
| 624 | + | |
623 | 625 | | |
624 | 626 | | |
625 | 627 | | |
| |||
655 | 657 | | |
656 | 658 | | |
657 | 659 | | |
658 | | - | |
659 | | - | |
660 | | - | |
661 | | - | |
| 660 | + | |
| 661 | + | |
| 662 | + | |
| 663 | + | |
| 664 | + | |
| 665 | + | |
| 666 | + | |
| 667 | + | |
662 | 668 | | |
0 commit comments