Skip to content

Misleading output of "No issues found!" when a model is skipped#218

Description

@peng-hui

Describe the bug
Modelscan skips a model if it identifies invalid magic number (header) of the model. However, it would still print out

 --- Summary ---

 No issues found! 馃帀

--- Skipped ---

Total skipped: 1 - run with --show-skipped to see the full list.

This is kind of misleading because incautious users might ignore the line about the skipped model.

I understand the modelscan produces a different non-zero exit code but I suppose people might not check the exit code.

To Reproduce
Steps to reproduce the behavior:

  1. run on a model with an invalid magic number, for example: https://huggingface.co/sentence-transformers/paraphrase-MiniLM-L6-v2/blob/main/openvino/openvino_model.bin
  2. modelscan -p openvino_model.bin

Expected behavior
I would expect modelscan to show: modelscan does not know if there is an issue because the model is skipped.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

Additional context
Add any other context about the problem here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions