Commit 1524c5e
committed
fix(web): disable archive on running threads and fix misleading failure toast
Macroscope and Cursor Bugbot flagged two real issues in the single-thread
archive path (sidebar row menu and chat header menu): the menu item stayed
enabled while a thread had an active turn, so it always failed against
archiveThread's ThreadArchiveBlockedError guard, and any failure after a
successful archive (e.g. the post-archive navigation to a new thread) was
reported as "Failed to archive thread" even though the thread had already
been archived. Both are already handled correctly in the bulk-archive path
(buildMultiSelectThreadContextMenuItems disables on hasRunningThread, and
archiveSelectedThreadEntries distinguishes a post-archive navigation
failure); this brings the single-thread path in line with that pattern.1 parent e2cc16e commit 1524c5e
4 files changed
Lines changed: 35 additions & 4 deletions
File tree
- apps/web/src
- components
- hooks
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2964 | 2964 | | |
2965 | 2965 | | |
2966 | 2966 | | |
| 2967 | + | |
| 2968 | + | |
2967 | 2969 | | |
2968 | 2970 | | |
2969 | 2971 | | |
| |||
3074 | 3076 | | |
3075 | 3077 | | |
3076 | 3078 | | |
3077 | | - | |
| 3079 | + | |
| 3080 | + | |
| 3081 | + | |
| 3082 | + | |
| 3083 | + | |
| 3084 | + | |
3078 | 3085 | | |
3079 | 3086 | | |
3080 | 3087 | | |
3081 | 3088 | | |
3082 | 3089 | | |
3083 | | - | |
| 3090 | + | |
| 3091 | + | |
| 3092 | + | |
3084 | 3093 | | |
3085 | 3094 | | |
3086 | 3095 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
| |||
80 | 81 | | |
81 | 82 | | |
82 | 83 | | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
83 | 91 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| 34 | + | |
| 35 | + | |
34 | 36 | | |
35 | 37 | | |
36 | 38 | | |
| |||
108 | 110 | | |
109 | 111 | | |
110 | 112 | | |
111 | | - | |
| 113 | + | |
112 | 114 | | |
113 | 115 | | |
114 | 116 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
139 | 139 | | |
140 | 140 | | |
141 | 141 | | |
| 142 | + | |
142 | 143 | | |
143 | 144 | | |
144 | 145 | | |
| |||
260 | 261 | | |
261 | 262 | | |
262 | 263 | | |
263 | | - | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
264 | 276 | | |
265 | 277 | | |
266 | 278 | | |
| |||
0 commit comments