fix(drizzle): dedupe reused localized block tables - #17430
Merged
Conversation
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
DanRibbens
approved these changes
Jul 21, 2026
Contributor
|
🚀 This is included in version v3.87.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes duplicate
_Nblock tables when identicalblockReferencesare reused under localized block paths.Fixes #17424.
traverseFieldsvalidated existing block tables with the immediatefield.localizedflag, which dropped localization inherited from ancestor blocks and arrays.validateExistingBlockIsIdenticalnever receivedparentIsLocalizedfrom this call site, so nested block fields were flattened with incomplete localization context.The fix passes the accumulated localization context into
validateExistingBlockIsIdenticaland reuses the same localized-table calculation that schema construction already uses when deciding whether an existing block table matches.Adds a regression spec that builds two localized collections reusing the same nested
headlineblock reference and asserts Payload does not create suffixed duplicate tables likepages_blocks_headline_2orposts_blocks_headline_2.