From ad575d614102f4a4b0087bfdb821ca0084c4bc1a Mon Sep 17 00:00:00 2001 From: Manoj Vivek Date: Tue, 25 Feb 2025 14:36:44 +0530 Subject: [PATCH 1/3] Hiding the 'root' node from the stacks in flamecharts as it doesn't serve any purpose there --- .../IcicleGraphArrow/IcicleChartRootNode.tsx | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/ui/packages/shared/profile/src/ProfileIcicleGraph/IcicleGraphArrow/IcicleChartRootNode.tsx b/ui/packages/shared/profile/src/ProfileIcicleGraph/IcicleGraphArrow/IcicleChartRootNode.tsx index 11b55247e2b..3e41ad3d057 100644 --- a/ui/packages/shared/profile/src/ProfileIcicleGraph/IcicleGraphArrow/IcicleChartRootNode.tsx +++ b/ui/packages/shared/profile/src/ProfileIcicleGraph/IcicleGraphArrow/IcicleChartRootNode.tsx @@ -96,30 +96,13 @@ export const IcicleChartRootNode = React.memo(function IcicleChartRootNodeNonMem return ( - - - - - root - - - Date: Tue, 25 Feb 2025 14:41:11 +0530 Subject: [PATCH 2/3] Disable clicks in flamecharts --- .../profile/src/ProfileView/components/DashboardItems/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/packages/shared/profile/src/ProfileView/components/DashboardItems/index.tsx b/ui/packages/shared/profile/src/ProfileView/components/DashboardItems/index.tsx index 7b75d0989f5..94ab82074f8 100644 --- a/ui/packages/shared/profile/src/ProfileView/components/DashboardItems/index.tsx +++ b/ui/packages/shared/profile/src/ProfileView/components/DashboardItems/index.tsx @@ -107,7 +107,7 @@ export const getDashboardItem = ({ return ( {}} arrow={flamechartData?.arrow} total={total} filtered={filtered} From 0de5293258abbca526cdc122584c6b6ebc72f00c Mon Sep 17 00:00:00 2001 From: Manoj Vivek Date: Tue, 25 Feb 2025 14:59:16 +0530 Subject: [PATCH 3/3] Linter fix --- .../IcicleGraphArrow/IcicleChartRootNode.tsx | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/ui/packages/shared/profile/src/ProfileIcicleGraph/IcicleGraphArrow/IcicleChartRootNode.tsx b/ui/packages/shared/profile/src/ProfileIcicleGraph/IcicleGraphArrow/IcicleChartRootNode.tsx index 3e41ad3d057..93296db2755 100644 --- a/ui/packages/shared/profile/src/ProfileIcicleGraph/IcicleGraphArrow/IcicleChartRootNode.tsx +++ b/ui/packages/shared/profile/src/ProfileIcicleGraph/IcicleGraphArrow/IcicleChartRootNode.tsx @@ -13,9 +13,6 @@ import React, {Fragment} from 'react'; -import cx from 'classnames'; -import twColors from 'tailwindcss/colors'; - import {scaleLinear} from '@parca/utilities'; import {FIELD_CHILDREN, FIELD_CUMULATIVE, FIELD_DURATION, FIELD_TIMESTAMP} from '.'; @@ -33,7 +30,6 @@ export const IcicleChartRootNode = React.memo(function IcicleChartRootNodeNonMem colors, colorBy, y, - height, setCurPath, curPath, level, @@ -102,7 +98,7 @@ export const IcicleChartRootNode = React.memo(function IcicleChartRootNodeNonMem colors={colors} colorBy={colorBy} x={x} - y={0} + y={y} totalWidth={width ?? 1} height={RowHeight} setCurPath={setCurPath}