[FSSDK-12813] Remove ticket references from code comments per cross-sdk guideline

Author: jaeopt

optimizely/event/event_factory.py

@@ -135,12 +135,6 @@ def _create_visitor(cls, event: Optional[user_event.UserEvent], logger: Logger)
                 if isinstance(event.experiment, entities.Experiment):
                     experiment_layerId = event.experiment.layerId
 
-            # FSSDK-12813: Normalize decision-event IDs uniformly across all
-            # decision types (experiment, feature test, rollout, holdout).
-            # campaign_id falls back to experiment_id when invalid.
-            # variation_id becomes None when invalid.
-            # entity_id on the impression event mirrors campaign_id (FR-009)
-            # so the two fields are byte-equivalent for the same event.
             normalized_campaign_id = event_id_normalizer.normalize_campaign_id(
                 experiment_layerId, experiment_id
             )

optimizely/event/event_id_normalizer.py

@@ -15,7 +15,7 @@
 
 This module provides byte-equivalent, cross-SDK normalization for the
 ``campaign_id``, ``variation_id``, and impression ``entity_id`` fields that
-appear in dispatched decision events. See FSSDK-12813.
+appear in dispatched decision events.
 
 Rules:
   * ``campaign_id`` and impression ``entity_id`` accept **any non-empty

optimizely/event/payload.py

@@ -80,9 +80,6 @@ def __init__(
     ):
         self.campaign_id = campaign_id
         self.experiment_id = experiment_id
-        # FSSDK-12813: variation_id may be None when input is invalid /
-        # non-numeric (FR-003/FR-004). All other decision fields remain
-        # strings.
         self.variation_id = variation_id
         self.metadata = metadata
 

optimizely/event_builder.py

@@ -191,10 +191,6 @@ def _get_required_params_for_impression(
     """
         snapshot: dict[str, list[dict[str, Any]]] = {}
 
-        # FSSDK-12813: Normalize decision-event IDs uniformly across all
-        # decision types. campaign_id falls back to experiment_id when
-        # invalid; variation_id becomes None when invalid; entity_id mirrors
-        # the normalized campaign_id (FR-009).
         normalized_campaign_id = event_id_normalizer.normalize_campaign_id(
             experiment.layerId, experiment.id
         )

tests/test_event_factory.py

@@ -1240,7 +1240,7 @@ def test_create_impression_event_without_cmab_uuid(self):
 
 
 class EventFactoryIdNormalizationIntegrationTest(base.BaseTest):
-    """FSSDK-12813: end-to-end decision-event ID normalization.
+    """End-to-end decision-event ID normalization.
 
     These tests build real ``ImpressionEvent`` instances using crafted
     Experiment/Variation objects, then call ``EventFactory.create_log_event``
@@ -1323,24 +1323,21 @@ def test_empty_campaign_id_falls_back_to_experiment_id(self):
         self.assertEqual('111127', event['entity_id'])
 
     def test_opaque_string_campaign_id_passes_through(self):
-        # FSSDK-12813: opaque (non-numeric) campaign_id values are valid and
-        # pass through unchanged per the relaxed FR-001 contract.
         impression = self._build_impression('111127', 'campaign_a', '111129')
         decision, event = self._dispatched_decision(impression)
         self.assertEqual('campaign_a', decision['campaign_id'])
         self.assertEqual('campaign_a', event['entity_id'])
 
     def test_prefixed_opaque_campaign_id_passes_through(self):
-        # FSSDK-12813: e.g. holdout layer IDs like "default-12345".
+        # Holdout layer IDs are opaque strings like "default-12345".
         impression = self._build_impression('111127', 'default-12345', '111129')
         decision, event = self._dispatched_decision(impression)
         self.assertEqual('default-12345', decision['campaign_id'])
         self.assertEqual('default-12345', event['entity_id'])
 
     def test_whitespace_campaign_id_passes_through(self):
-        # FSSDK-12813: whitespace is a non-empty string and so is accepted;
-        # character-content validation is deferred to the upstream datafile
-        # producer.
+        # Whitespace is a non-empty string; character-content validation is
+        # the upstream datafile producer's responsibility.
         impression = self._build_impression('111127', ' ', '111129')
         decision, event = self._dispatched_decision(impression)
         self.assertEqual(' ', decision['campaign_id'])
@@ -1370,8 +1367,6 @@ def test_whitespace_variation_id_becomes_none(self):
 
     # ------------------------------------------------------------------ FR-005
     def test_normalization_applies_to_rollout_decisions(self):
-        # FSSDK-12813: empty campaign_id falls back to experiment_id;
-        # non-numeric variation_id normalizes to None.
         impression = self._build_impression(
             '111127', '', 'bad_var', rule_type='rollout'
         )
@@ -1399,8 +1394,8 @@ def test_normalization_applies_to_holdout_decisions(self):
         self.assertEqual('111127', event['entity_id'])
 
     def test_holdout_with_opaque_layer_id_passes_through(self):
-        # FSSDK-12813: the canonical holdout case — opaque layerId like
-        # "default-12345" is now a valid campaign_id and is NOT replaced.
+        # Canonical holdout case: opaque layerId like "default-12345" is a
+        # valid campaign_id and must not be replaced.
         impression = self._build_impression(
             '111127', 'default-12345', '111129', rule_type='holdout'
         )
@@ -1427,7 +1422,7 @@ def test_entity_id_equals_campaign_id_byte_for_byte(self):
         for layer_id, exp_id, expected in [
             ('111182', '111127', '111182'),         # numeric campaign_id wins
             ('', '111127', '111127'),                # empty falls back to experiment_id
-            # FSSDK-12813: opaque non-numeric IDs now pass through unchanged.
+            # Opaque non-numeric IDs pass through unchanged.
             ('default-12345', '111127', 'default-12345'),
             ('layer_abc', '111127', 'layer_abc'),
             ('007', '111127', '007'),                # leading zeros preserved

tests/test_event_id_normalizer.py

@@ -11,7 +11,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-"""Unit tests for :mod:`optimizely.event.event_id_normalizer` (FSSDK-12813)."""
+"""Unit tests for :mod:`optimizely.event.event_id_normalizer`."""
 
 import unittest
 
@@ -143,7 +143,7 @@ def test_returns_campaign_id_when_numeric(self):
         )
 
     def test_returns_campaign_id_when_opaque_string(self):
-        # FSSDK-12813: opaque IDs (e.g. holdout layer IDs) pass through.
+        # Opaque IDs (e.g. holdout layer IDs) pass through.
         self.assertEqual(
             'default-12345',
             event_id_normalizer.normalize_campaign_id('default-12345', '111127'),