fix(ci): pay attention to --ignore-scripts - #2455
Merged
Merged
Conversation
wraithgar
force-pushed
the
gar/ci_ignore_scripts
branch
from
January 7, 2021 17:18
2461e76 to
91ed645
Compare
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
ruyadorno
approved these changes
Jan 7, 2021
nlf
approved these changes
Jan 7, 2021
Added a test for install too for this specific condition PR-URL: #2455 Credit: @wraithgar Close: #2455 Reviewed-by: @isaacs
isaacs
force-pushed
the
gar/ci_ignore_scripts
branch
from
January 7, 2021 20:45
91ed645 to
907b34b
Compare
3 tasks
This was referenced May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm cidoes not enforce the--ignore-scriptsoption. Now it does.Also added a test for
npm install --ignore-scriptsReferences
Closes #2434