-
-
Notifications
You must be signed in to change notification settings - Fork 35.6k
Landing npm 4 into node 7 #10505
Copy link
Copy link
Closed
Labels
npmIssues and PRs related to the npm client dependency or the npm registry.Issues and PRs related to the npm client dependency or the npm registry.
Metadata
Metadata
Assignees
Labels
npmIssues and PRs related to the npm client dependency or the npm registry.Issues and PRs related to the npm client dependency or the npm registry.
Type
Fields
Give feedbackNo fields configured for issues without a type.
If you want to support landing this please react with emojis to this post rather than posting your support in this thread, thank you
npm v4 just landed into master in 9946519
The CTC has discussed landing npm 4 into node 7 and so far all discussion has been positive. One of the biggest reasons is to get the deprecation warnings around
prepublishinto as many hands as possible to avoid confusion if npm 5 ships with node 8The only hesitation so far has been the dropping of support of partial shrinkwraps.
This did at one point break hapi, but was fixed in hapijs/hapi@0ca8cea (thanks for pointing that out @iarna). It is worth mentioning that this will likely break older hapi builds on npm4 if the change was not backported.
It might be a good idea to scan the registry and find out what other projects are currently shipping broken shrinkwraps so we can better estimate ecosystem brekages, /cc @ChALkeR.
Please chime in if you have any concerns, we can bring this to the ctc again next week.
/cc @nodejs/npm