Skip to content

Commit f1e2dc6

Browse files
committed
squash!: add comment about using config property
1 parent 0d943f4 commit f1e2dc6

1 file changed

Lines changed: 8 additions & 1 deletion

File tree

test/parallel/test-process-env-allowed-flags-are-documented.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,14 @@ const conditionalOpts = [
4646
return ['--openssl-config', '--tls-cipher-list', '--use-bundled-ca',
4747
'--use-openssl-ca' ].includes(opt);
4848
} },
49-
{ include: process.config.variables.openssl_is_fips,
49+
{
50+
// We are using openssl_is_fips from the configuration because it could be
51+
// the case that OpenSSL is FIPS compatible but fips has not been enabled
52+
// (starting node with --enable-fips). If we use common.hasFipsCrypto
53+
// that would only tells us if fips has been enabled, but in this case we
54+
// want to check options which will be available regardless of whether fips
55+
// is enabled at runtime or not.
56+
include: process.config.variables.openssl_is_fips,
5057
filter: (opt) => opt.includes('-fips') },
5158
{ include: common.hasIntl,
5259
filter: (opt) => opt === '--icu-data-dir' },

0 commit comments

Comments
 (0)