chore: selectively import required semver functions - #511
Merged
Merged
Conversation
merceyz
approved these changes
Jul 11, 2024
By selectively importing only the functions we want, we avoid bundling in the entire semver package, which brings impressive savings. Before: ``` wmaj@MacBook-Air corepack % yarn build dist/lib/corepack.cjs 949.5kb ``` After: ``` wmaj@MacBook-Air corepack % yarn build dist/lib/corepack.cjs 924.7kb ```
aduh95
approved these changes
Jul 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By selectively importing only the functions we want, we avoid bundling in the entire semver package, which results in impressive savings of roughly 25 KB.
Before:
After:
It also (minimally) reduces execution time: