feat: enable elliptic curve es256 for JWS - #205
Merged
Merged
Conversation
kalinkrustev
marked this pull request as ready for review
June 21, 2024 12:26
kalinkrustev
requested review from
bushjames,
elnyry-sam-k,
kirgene,
kleyow,
lewisdaly and
mdebarros
as code owners
June 21, 2024 12:26
elnyry-sam-k
previously approved these changes
Jul 3, 2024
Member
|
We have option for both so I'm good for now. We need to continue to use the RS256 on prod / official deployments until the new algorithm is approved by CCB / FSPIOP SIG. |
|
kalinkrustev
changed the title
kalinkrustev
changed the title
Contributor
Author
|
@elnyry-sam-k , this needs an approval again, as there were merge conflicts and dependency updates |
elnyry-sam-k
approved these changes
Jul 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #203
The result is available here and shows much better performance when using ES256: