chore(#864): change instanbul to nyc for coverage on all projects (#191)

chore(#864): change instanbul to nyc for coverage on all projects

- Added .nycrc.yml with standard Mojaloop code-coverage milestones
- Updated test:coverage & test:coverage-check script in package.json - removed unnecessary configs defined in the .nycrc.yml
- Added Todo in README.md with note about future code-coverage improvements
- Minor bump to patch level to reflect dependency updates
- Fixed audit-resolve issues:

```text
--------------------------------------------------
 tar needs your attention.

[ high ] Arbitrary File Creation/Overwrite due to insufficient absolute path sanitization
 vulnerable versions <3.2.2 || >=4.0.0 <4.4.14 || >=5.0.0 <5.0.6 || >=6.0.0 <6.1.1 found in:
 - dependencies: @mojaloop/event-sdk>grpc>@mapbox/node-pre-gyp>tar
[ high ] Arbitrary File Creation/Overwrite via insufficient symlink protection due to directory cache poisoning
 vulnerable versions <3.2.3 || >=4.0.0 <4.4.15 || >=5.0.0 <5.0.7 || >=6.0.0 <6.1.2 found in:
 - dependencies: @mojaloop/event-sdk>grpc>@mapbox/node-pre-gyp>tar
```

> Outcome: Fixed

```text
--------------------------------------------------
 yargs-parser needs your attention.

[ low ] Prototype Pollution
 vulnerable versions <13.1.2 || >=14.0.0 <15.0.1 || >=16.0.0 <18.1.2 found in:
 - dependencies: @mojaloop/central-services-shared>widdershins>yargs>yargs-parser
 --------------------------------------------------
 sanitize-html needs your attention.

[ moderate ] Improper Input Validation
 vulnerable versions <2.3.1 found in:
 - dependencies: @mojaloop/central-services-shared>shins>sanitize-html
[ moderate ] Improper Input Validation
 vulnerable versions <2.3.2 found in:
 - dependencies: @mojaloop/central-services-shared>shins>sanitize-html
```

> Outcome: Ignored for a week
> Impact: Minimal as this is used to render documentation end-point

Author: mdebarros

.nycrc.yml

@@ -0,0 +1,19 @@
+temp-directory: "./.nyc_output"
+check-coverage: true
+per-file: true
+lines: 90
+statements: 90
+functions: 90
+# branches: 90 ## TODO: This should be un-commented to 90 once code-coverage is improved!
+all: true
+include: [
+  "src/**/*.js"
+]
+reporter: [
+  "lcov"
+]
+exclude: [
+  "src/setup.js", # Ignoring this until there is a reason to test this file. Currently just exports the library functions.
+  "src/lib/kafka/index.js", # Ignoring this until there is a reason to test this file. Currently just exports the library functions.
+  "**/node_modules/**"
+]

README.md

@@ -8,13 +8,19 @@ Email Notifier is a stand-alone email service that consumes messages from kafka
 The central-event-processor repo is available [here](https://github.com/mojaloop/central-event-processor/tree/master)  
 The email-notifier flow is available [here](https://github.com/mojaloop/central-event-processor/tree/master#Notifierflowseparateservice)  
 
-## Contents:
+## Contents
 
-- [Config](#config)
-- [Troubleshooting](#troubleshooting-npm-install-on-macos)
-- [Auditing Dependencies](#auditing-dependencies)
-- [Container Scans](#container-scans)
+- [email-notifier](#email-notifier)
+  - [Contents](#contents)
+  - [Todo](#todo)
+  - [Config](#config)
+  - [Troubleshooting `npm install` on MacOS](#troubleshooting-npm-install-on-macos)
+  - [Auditing Dependencies](#auditing-dependencies)
+  - [Container Scans](#container-scans)
 
+## Todo
+
+- Improve code-coverage to 90% across the board: [.nycrc.yml](./.nycrc.yml). Don't forget to un-comment out the branches code-coverage rule.
 
 ## Config
 

audit-resolve.json

@@ -74,27 +74,35 @@
     },
     "1500|@mojaloop/central-services-shared>widdershins>yargs>yargs-parser": {
       "decision": "ignore",
-      "madeAt": 1623667801477,
-      "expiresAt": 1624272585565
+      "madeAt": 1629388382628,
+      "expiresAt": 1629993162001
     },
     "1751|@mojaloop/central-services-shared>shins>chokidar>glob-parent": {
       "decision": "fix",
       "madeAt": 1623667798314
     },
     "1675|@mojaloop/central-services-shared>shins>sanitize-html": {
       "decision": "ignore",
-      "madeAt": 1623667803515,
-      "expiresAt": 1624272585565
+      "madeAt": 1629388385750,
+      "expiresAt": 1629993162001
     },
     "1676|@mojaloop/central-services-shared>shins>sanitize-html": {
       "decision": "ignore",
-      "madeAt": 1623667803515,
-      "expiresAt": 1624272585565
+      "madeAt": 1629388385750,
+      "expiresAt": 1629993162001
     },
     "1693|@mojaloop/central-services-shared>shins>sanitize-html>postcss": {
       "decision": "ignore",
       "madeAt": 1623667805440,
       "expiresAt": 1624272585565
+    },
+    "1770|@mojaloop/event-sdk>grpc>@mapbox/node-pre-gyp>tar": {
+      "decision": "fix",
+      "madeAt": 1629388377186
+    },
+    "1771|@mojaloop/event-sdk>grpc>@mapbox/node-pre-gyp>tar": {
+      "decision": "fix",
+      "madeAt": 1629388377187
     }
   },
   "rules": {},