PR for Issue #915 - Apply FSPIOP error handling (#40)

* Per Sonar modify code to solve 2 bugs and 1 vulnerability, ran unit tests after changes

* Update PR user logger instead of console log and use modern and consistent function definition syntax

* Issue #915 - Apply FSPIOP error handling

-remove package-lock.json from .gitignore
-update package.json depedendencies and scripts
-update existing error handling with FSPIOPError framework
-update unit tests as required by update to existing error handling with FSPIOPError framework

* 915 - Updates to config files

-version change to match PI sprint
-fix instanbul version

* 915 - Updates to PR

-update circleci config
-update package.json dependencies and scripts
-remove createPrepareErrorStatus

* 915 - Update PR

-update circleci test xunit script

Author: gibaros

.circleci/config.yml

@@ -173,32 +173,32 @@ jobs:
           paths:
             - node_modules
 
-  # test-unit:
-  #   <<: *defaults_working_directory
-  #   <<: *defaults_docker_node
-  #   steps:
-  #     - checkout
-  #     - run:
-  #         name: Install general dependencies
-  #         command: *defaults_Dependencies
-  #     - run:
-  #         <<: *defaults_environment
-  #     - restore_cache:
-  #         key: dependency-cache-{{ checksum "package.json" }}
-  #     - run:
-  #         name: Install tape, tapes and tap-xunit
-  #         command: npm install -g tape tapes tap-xunit
-  #     - run:
-  #         name: Create dir for test results
-  #         command: mkdir -p ./test/results
-  #     - run:
-  #         name: Execute unit tests
-  #         command: npm -s run test:xunit > ./test/results/tape.xml
-  #     - store_artifacts:
-  #         path: ./test/results
-  #         prefix: test
-  #     - store_test_results:
-  #         path: ./test/results
+  test-unit:
+    <<: *defaults_working_directory
+    <<: *defaults_docker_node
+    steps:
+      - checkout
+      - run:
+          name: Install general dependencies
+          command: *defaults_Dependencies
+      - run:
+          <<: *defaults_environment
+      - restore_cache:
+          key: dependency-cache-{{ checksum "package.json" }}
+      - run:
+          name: Install tape, tapes and tap-xunit
+          command: npm install -g tape tapes tap-xunit
+      - run:
+          name: Create dir for test results
+          command: mkdir -p ./test/results
+      - run:
+          name: Execute unit tests
+          command: npm -s run test:xunit > ./test/results/tape.xml
+      - store_artifacts:
+          path: ./test/results
+          prefix: test
+      - store_test_results:
+          path: ./test/results
 
   # test-coverage:
   #   <<: *defaults_working_directory
@@ -502,17 +502,17 @@ workflows:
               ignore:
                 - /feature*/
                 - /bugfix*/
-      # - test-unit:
-      #     context: org-global
-      #     requires:
-      #       - setup
-      #     filters:
-      #       tags:
-      #         only: /.*/
-      #       branches:
-      #         ignore:
-      #           - /feature*/
-      #           - /bugfix*/
+      - test-unit:
+          context: org-global
+          requires:
+            - setup
+          filters:
+            tags:
+              only: /.*/
+            branches:
+              ignore:
+                - /feature*/
+                - /bugfix*/
       # - test-coverage:
       #     context: org-global
       #     requires:

.gitignore

@@ -37,7 +37,6 @@ build/Release
 # Dependency directories
 node_modules/
 jspm_packages/
-package-lock.json
 
 # TypeScript v1 declaration files
 typings/