Skip to content

Add support for load multiple files by values defined in NODE_ENV - #486

Merged
lorenwest merged 2 commits into
node-config:masterfrom
leonardovillela:node-env-define-multiple-load-files
May 31, 2018
Merged

Add support for load multiple files by values defined in NODE_ENV#486
lorenwest merged 2 commits into
node-config:masterfrom
leonardovillela:node-env-define-multiple-load-files

Conversation

@leonardovillela

Copy link
Copy Markdown
Contributor

@leonardovillela

Copy link
Copy Markdown
Contributor Author

Hello Guys, any problem with this PR? I can help with something?

@lorenwest

Copy link
Copy Markdown
Collaborator

Thank you for your patience - I've been pretty busy lately.

Comment thread test/14-config/bare-metal.json Outdated
"db": {
"name": "bare-metal-config-env-provided"
}
} No newline at end of file

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you've removed the final newline in these files. Could you un-do those changes?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, i will update this

@lorenwest

Copy link
Copy Markdown
Collaborator

This looks good - thank you for adding this feature. Only one comment in the code review - if you could undo those newline removals and re-issue the PR, I'll get it merged.

@lorenwest
lorenwest merged commit 66bd8e1 into node-config:master May 31, 2018
@lorenwest

Copy link
Copy Markdown
Collaborator

@leonardovillela - We are having a conversation on #484 regarding including this in a major version bump. Will get this published as soon as we conclude that version bump issue.

@KrishnaPG

Copy link
Copy Markdown

Would default be still loaded in case multiple env are specified?

@markstos

markstos commented May 5, 2021

Copy link
Copy Markdown
Collaborator

I noticed the wiki was never updated to reflect this change. Documenting it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants