Skip to content

fix: clean up single group value after unmount closes #3963 - #3972

Merged
logaretm merged 1 commit into
mainfrom
fix/3963
Oct 23, 2022
Merged

fix: clean up single group value after unmount closes #3963#3972
logaretm merged 1 commit into
mainfrom
fix/3963

Conversation

@logaretm

Copy link
Copy Markdown
Owner

What

Fixes an issue where values of group fields with non-array value like radio inputs are not cleaned up on unmount

closes #3963

@codecov-commenter

codecov-commenter commented Oct 23, 2022

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.91%. Comparing base (a4603fa) to head (900573d).
⚠️ Report is 529 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3972   +/-   ##
=======================================
  Coverage   95.91%   95.91%           
=======================================
  Files          68       68           
  Lines        2006     2009    +3     
  Branches      515      517    +2     
=======================================
+ Hits         1924     1927    +3     
  Misses         82       82           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@logaretm
logaretm merged commit 8ccfd2b into main Oct 23, 2022
@logaretm
logaretm deleted the fix/3963 branch October 23, 2022 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[V4] The value of radio fields is kept by the form even when hidden

2 participants