feat: chain of GenericValidateFunction in useField (#3725) - #3726
Merged
logaretm merged 1 commit intoMar 20, 2022
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3726 +/- ##
==========================================
+ Coverage 96.35% 96.38% +0.02%
==========================================
Files 68 68
Lines 1838 1853 +15
Branches 457 463 +6
==========================================
+ Hits 1771 1786 +15
Misses 67 67 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
logaretm
approved these changes
Mar 20, 2022
Owner
|
This is a welcome addition, thank you! |
logaretm
added a commit
that referenced
this pull request
Mar 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔎 Overview
This PR adds the feature to use a chain of GenericValidateFunction in rules for useField, and allows it to return multiple errors if bails is set to false.
🤓 Code snippets/examples (if applicable)
If value is not set and and validation is run, errors will be:
If bails is true, it will break on the first non passing validation and return a single error. Following this example:
Validations are run following the order they are specified.
✔ Issues affected
closes #3725