Skip to content

Commit 8079adc

Browse files
committed
[Tests] parse: remove a test that pinned []= comma groups escaping arrayLimit
`a[]=1,2,3,4,5,6` with `arrayLimit: 5` and `throwOnLimitExceeded: true` was asserted not to throw, under a title claiming the group was "within arrayLimit". The group has six elements; the test pinned the very gap the README and threat model say `throwOnLimitExceeded` closes.
1 parent d56f48c commit 8079adc

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

‎test/parse.js‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1589,12 +1589,6 @@ test('parse()', function (t) {
15891589
sst.end();
15901590
});
15911591

1592-
st.test('does not throw for a bracketed comma group within arrayLimit', function (sst) {
1593-
var result = qs.parse('a[]=1,2,3,4,5,6', { comma: true, arrayLimit: 5, throwOnLimitExceeded: true });
1594-
sst.deepEqual(result, { a: [['1', '2', '3', '4', '5', '6']] }, 'a bracketed comma group is a single element');
1595-
sst.end();
1596-
});
1597-
15981592
st.test('throws for a bracketed comma group when arrayLimit is 0', function (sst) {
15991593
sst['throws'](
16001594
function () {

0 commit comments

Comments
 (0)