Add hostsToRewrite option and advanced-options page. - #809
Merged
leonstafford merged 2 commits intoSep 21, 2021
Conversation
john-shaffer
force-pushed
the
hosts-to-rewrite-option
branch
from
September 19, 2021 02:15
5dc6ce3 to
62ed042
Compare
Contributor
|
Looks good! Could we adjust to allow not rewriting anything, for those cases where people are locally hosting on an identical hostname as their deployment one? (+ minor naming suggestion) |
leonstafford
suggested changes
Sep 19, 2021
leonstafford
left a comment
leonstafford
left a comment
Contributor
There was a problem hiding this comment.
just the naming + Q whether we should allow skipping rewriting hostnames completely
john-shaffer
marked this pull request as draft
September 20, 2021 23:36
john-shaffer
force-pushed
the
hosts-to-rewrite-option
branch
from
September 21, 2021 00:15
62ed042 to
65b6e5d
Compare
john-shaffer
marked this pull request as ready for review
September 21, 2021 00:16
Contributor
Author
|
Implemented |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate host rewriting functionality from the advanced crawling addon, with improvements.
It's useful to rewrite hosts other than the one we are crawling. Often there are links which reference a development or staging URL that we want to replace. This can also be used to rewrite http://deployment-url.com to https://deployment-url.com.
The incidental change from str_replace to strtr may fix some of the reported bugs with the host rewriting.